Skip to content

OCPBUGS-68350: In OCB to check when a image is removed the old build is triggered again and the MC should start updating directly and no new MOSB should be triggred #6150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric200428 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Open

OCPBUGS-68350: In OCB to check when a image is removed the old build is triggered again and the MC should start updating directly and no new MOSB should be triggred #6150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce58f78
Added a if-statement to compare images
eric200428 Jun 5, 2026
23696fb
Added check for missingAnnotation
eric200428 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/controller/build/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1390,6 +1390,12 @@ func (b *buildReconciler) reconcilePoolChange(ctx context.Context, mcp *mcfgv1.M
// In both cases, we need to create/continue a build
missingAnnotation := firstOptIn == ""

// No action needed if the rendered config has not changed.
if oldRendered == newRendered && !missingAnnotation {
klog.V(4).Infof("pool %q: Configuration unchanged (%s), no action needed", mcp.Name, oldRendered)
return nil
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

// This is our trigger point
// Create/continue a build if:
// 1. Config changed AND needs image rebuild, OR
Expand Down