SREP-3321: Improve log clarity for delete-olm-operator dry-run mode

[clcollins]

Summary

Improves log output clarity for the operators-lifecycle/delete-olm-operator managed job to prevent operational confusion during incident response.

Problem

During incident response, SREs ran the delete-olm-operator job without the FORCE=y parameter and incorrectly assumed the job had completed its work when it was only describing what would be deleted. The previous log output used ambiguous language like "Will delete..." which sounded like future action rather than hypothetical action.

Changes

• Added prominent dry-run mode banner at script start with clear "DRY-RUN MODE - NO CHANGES" heading
• Prefixed all dry-run messages with [DRY-RUN] for immediate visual distinction
• Changed wording from "Will delete" to "Would delete" to clarify these are hypothetical actions
• Added final summary banners for both dry-run and execution modes
• Included clear instructions to execute with --params FORCE=y in both banner messages

Benefits

• Prevents operational mistakes during incident response
• Reduces incident duration by avoiding confusion about job execution status
• Makes dry-run functionality more obvious and usable
• Improves SRE confidence in managed job operations

Test Plan

• Confirm shellcheck validation passes
• Run job in dry-run mode (without FORCE=y) and verify clear messaging
• Run job in execution mode (with FORCE=y) and verify success banner
• Get team feedback on log clarity

Related: https://issues.redhat.com/browse/SREP-3321

🤖 Generated with Claude Code

[openshift-ci-robot]

@clcollins: This pull request references SREP-3321 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

Improves log output clarity for the operators-lifecycle/delete-olm-operator managed job to prevent operational confusion during incident response.

Problem

During incident response, SREs ran the delete-olm-operator job without the FORCE=y parameter and incorrectly assumed the job had completed its work when it was only describing what would be deleted. The previous log output used ambiguous language like "Will delete..." which sounded like future action rather than hypothetical action.

Changes

• Added prominent dry-run mode banner at script start with clear "DRY-RUN MODE - NO CHANGES" heading
• Prefixed all dry-run messages with [DRY-RUN] for immediate visual distinction
• Changed wording from "Will delete" to "Would delete" to clarify these are hypothetical actions
• Added final summary banners for both dry-run and execution modes
• Included clear instructions to execute with --params FORCE=y in both banner messages

Benefits

• Prevents operational mistakes during incident response
• Reduces incident duration by avoiding confusion about job execution status
• Makes dry-run functionality more obvious and usable
• Improves SRE confidence in managed job operations

Test Plan

• Confirm shellcheck validation passes
• Run job in dry-run mode (without FORCE=y) and verify clear messaging
• Run job in execution mode (with FORCE=y) and verify success banner
• Get team feedback on log clarity

Related: https://issues.redhat.com/browse/SREP-3321

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clcollins
Once this PR has been reviewed and has the lgtm label, please assign typeid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@clcollins: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.