OU-1177: DashboardListPage Create Button #734
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@zhuje: This pull request references OU-1177 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
cc: @jgbernalp |
|
|
||
| if (!selectedProject || !dashboardName.trim()) { | ||
| const errors: { [key: string]: string } = {}; | ||
| if (!selectedProject) errors.project = 'Project is required'; |
There was a problem hiding this comment.
all static texts should always have translations
There was a problem hiding this comment.
Adding translations in the latest push.
…ustom, remove <PageSection /> because we are overriding padding
|
It looks like the create button is too wide. Can we set it so it automatically takes the width of the "Create" text? Other than than LGMT |
I replaced the 'Grid' with the 'Split' component to reduce the size of the create button. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, zhuje The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
OU-1177 DashboardListPage] Create Button
OU-1173 [DashboardPage / DashboardListPage] Reduce Vertical spacing page title + description
OU-1179 [DashboardListPage] Remove BreadCrumb
Screen.Recording.2026-01-15.at.6.11.50.PM.mov