Skip to content

Conversation

@tremes
Copy link
Contributor

@tremes tremes commented Jan 20, 2026

This is adding a new cluster-health-analyzer feature so that the incident page is still displayed when this feature is enabled. It's related to the rhobs/observability-operator#976

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2026

@tremes: This pull request references COO-1515 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This is adding a new cluster-health-analyzer feature so that the incident page is still displayed when this feature is enabled. It's related to the rhobs/observability-operator#976

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jgbernalp
Copy link
Contributor

This might create the problem that 2 incidents tabs are added if incidents and health analyzer are both active. I think a better approach would be to keep the config/cluster-health-analyzer.patch.json remove the old incidents patch, having a single patch. And add logic to the go server to apply the patch in the case incidents or health analyzer features are enabled. Something similar to what we did in the logging plugin: https://github.com/openshift/logging-view-plugin/blob/main/pkg/server/manifest_handler.go#L44

@tremes tremes marked this pull request as ready for review January 20, 2026 12:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2026
@openshift-ci openshift-ci bot requested review from jgbernalp and zhuje January 20, 2026 12:04
@jgbernalp
Copy link
Contributor

/lgtm

@jgbernalp
Copy link
Contributor

/test e2e-monitoring

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants