[OSDOCS#17442]Updated product names as per CQA template in Prepare your environment section. #105604
Conversation
openshift-ci
bot
added
the
size/S
|
This is outside scope for this PR but while you're here, would you mind fixing the conditionals that are leading to these two typos: This would involve updating this section in the sd-planning-cluster-maximums.adoc module: Consider the following tested object maximums when you plan a {product-title} to: Consider the following tested object maximums when you plan |
AedinC
left a comment
AedinC
left a comment
There was a problem hiding this comment.
Looks great John. Just a couple of small suggestions.
| | `kube-system-control-plane-operator` | ||
| | `ROSAControlPlaneOperatorPolicy` | ||
| | An IAM role required control plane management on HCP clusters. | ||
| | An IAM role required for control plane management on HCP clusters. |
There was a problem hiding this comment.
| | An IAM role required for control plane management on HCP clusters. | |
| | An IAM role required for control plane management on hosted control planes (HCP) clusters. |
We should spell HCP out on first occurrence.
There was a problem hiding this comment.
@AedinC there was an occurrence just a couple of lines before, so I did the spelled out one there (just above on line 74)
Awesome, thanks Aedín, will make those changes. |
jheraght
force-pushed
the
OSDOCS-17442
branch
from
fdf1f48 to
cc0a8de
Compare
openshift-ci
bot
added
size/M
|
/retest |
|
@jheraght: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| [role="_abstract"] | ||
| Consider the following tested object maximums when you plan a {product-title} | ||
| Consider the following tested object maximums when you plan an {product-title} |
There was a problem hiding this comment.
You may need more conditionals.
On Classic, {product-title} resolves to Red Hat OpenShift Service on AWS. This module is currently included in rosa_planning/rosa-limits-scalability.adoc, but that assembly is currently commented out. Since it could be missed, I would do the conditionals for "a/an"
| cluster installation. The table specifies the maximum limits for each tested type in a | ||
| cluster installation. The table specifies the maximum limits for each tested type in an | ||
| ifdef::openshift-rosa[] | ||
| (ROSA) |
There was a problem hiding this comment.
We don't use ROSA anymore, and this would also be an "a/an" situation on ROSA.
| The maximum number of compute nodes on | ||
| ifdef::openshift-rosa[] | ||
| ROSA | ||
| {rosa-title} |
There was a problem hiding this comment.
| {rosa-title} | |
| {product-title} |
| When you install a {product-title} | ||
| When you install an {product-title} | ||
| ifdef::openshift-rosa[] | ||
| (ROSA) |
There was a problem hiding this comment.
| (ROSA) | |
| {product-title} |
|
|
||
| [role="_abstract"] | ||
| When you install a {product-title} | ||
| When you install an {product-title} |
There was a problem hiding this comment.
Same conditional comment as before.
| The maximum number of compute nodes on | ||
| ifdef::openshift-rosa[] | ||
| ROSA | ||
| {rosa-title} |
There was a problem hiding this comment.
| {rosa-title} | |
| {product-title} |
| The maximum number of compute nodes on | ||
| ifdef::openshift-rosa[] | ||
| ROSA | ||
| {rosa-title} |
There was a problem hiding this comment.
| {rosa-title} | |
| {product-title} |
4 participants
Version(s):
4.20+
Issue:
https://issues.redhat.com/browse/OSDOCS-17442
Link to docs preview:
Cluster-specific operator IAM role reference
Limits and scalability (OSD)
Peer review:
QE review:
Additional information: