Skip to content

ROX-35425: Fix unresolved {rhacs-version} in welcome page title (4.9)#114263

Open
vdurgam10 wants to merge 1 commit into
openshift:rhacs-docs-4.9from
vdurgam10:fix/ROX-35425-rhacs-version-4.9
Open

ROX-35425: Fix unresolved {rhacs-version} in welcome page title (4.9)#114263
vdurgam10 wants to merge 1 commit into
openshift:rhacs-docs-4.9from
vdurgam10:fix/ROX-35425-rhacs-version-4.9

Conversation

@vdurgam10

Copy link
Copy Markdown
Contributor

Summary

  • The welcome page title on docs.redhat.com for RHACS 4.9 displays the literal {rhacs-version} placeholder instead of the actual version number
  • Root cause: {rhacs-version} is defined in modules/common-attributes.adoc which is included after the title line — the Pantheon/AsciiBinder build pipeline resolves the title before processing includes, so the attribute is not available
  • Fix: Replace {rhacs-version} with {product-version} in the document title, which is injected by AsciiBinder from _distro_map.yml before parsing (consistent with all working versions 4.8 and earlier)

Bug

https://redhat.atlassian.net/browse/ROX-35425

Affected URL

https://docs.redhat.com/en/documentation/red_hat_advanced_cluster_security_for_kubernetes/4.9/html/about/welcome-index

Test plan

  • Verify local asciidoctor renders title as "Red Hat Advanced Cluster Security for Kubernetes 4.9 Documentation"
  • Verify published page no longer shows literal {rhacs-version} after merge and rebuild

Made with Cursor

The document title in welcome/index.adoc uses {rhacs-version}, which is
defined in modules/common-attributes.adoc included after the title line.
The Pantheon/AsciiBinder build pipeline resolves the title before
processing includes, causing the literal {rhacs-version} placeholder to
appear on docs.redhat.com.

Replace with {product-version}, which is injected globally by
AsciiBinder from _distro_map.yml before parsing, consistent with all
working versions (4.8 and earlier).

Fixes: https://redhat.atlassian.net/browse/ROX-35425
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 27, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 27, 2026

Copy link
Copy Markdown

@vdurgam10: This pull request references ROX-35425 which is a valid jira issue.

Details

In response to this:

Summary

  • The welcome page title on docs.redhat.com for RHACS 4.9 displays the literal {rhacs-version} placeholder instead of the actual version number
  • Root cause: {rhacs-version} is defined in modules/common-attributes.adoc which is included after the title line — the Pantheon/AsciiBinder build pipeline resolves the title before processing includes, so the attribute is not available
  • Fix: Replace {rhacs-version} with {product-version} in the document title, which is injected by AsciiBinder from _distro_map.yml before parsing (consistent with all working versions 4.8 and earlier)

Bug

https://redhat.atlassian.net/browse/ROX-35425

Affected URL

https://docs.redhat.com/en/documentation/red_hat_advanced_cluster_security_for_kubernetes/4.9/html/about/welcome-index

Test plan

  • Verify local asciidoctor renders title as "Red Hat Advanced Cluster Security for Kubernetes 4.9 Documentation"
  • Verify published page no longer shows literal {rhacs-version} after merge and rebuild

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 27, 2026
@openshift-ci

openshift-ci Bot commented Jun 27, 2026

Copy link
Copy Markdown

Hi @vdurgam10. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants