ROX-35425: Fix unresolved {rhacs-version} in welcome page title (4.10)#114264
ROX-35425: Fix unresolved {rhacs-version} in welcome page title (4.10)#114264vdurgam10 wants to merge 1 commit into
Conversation
The document title in welcome/index.adoc uses {rhacs-version}, which is
defined in modules/common-attributes.adoc included after the title line.
The Pantheon/AsciiBinder build pipeline resolves the title before
processing includes, causing the literal {rhacs-version} placeholder to
appear on docs.redhat.com.
Replace with {product-version}, which is injected globally by
AsciiBinder from _distro_map.yml before parsing, consistent with all
working versions (4.8 and earlier).
Fixes: https://redhat.atlassian.net/browse/ROX-35425
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@vdurgam10: This pull request references ROX-35425 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @vdurgam10. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
{rhacs-version}placeholder instead of the actual version number{rhacs-version}is defined inmodules/common-attributes.adocwhich is included after the title line — the Pantheon/AsciiBinder build pipeline resolves the title before processing includes, so the attribute is not available{rhacs-version}with{product-version}in the document title, which is injected by AsciiBinder from_distro_map.ymlbefore parsing (consistent with all working versions 4.8 and earlier)Bug
https://redhat.atlassian.net/browse/ROX-35425
Affected URL
https://docs.redhat.com/en/documentation/red_hat_advanced_cluster_security_for_kubernetes/4.10/html/about/welcome-index
Test plan
{rhacs-version}after merge and rebuildMade with Cursor