NO-JIRA: Refactor get_coredns_config: Use DynamicClient & testify/suite

[bentito]

This PR refactors the get_coredns_config tool introduced in #131 to align with the patterns established in #144.

Changes:

• Dynamic Client: Switched from controller-runtime client to DynamicClient for consistency with inspect_route.
• Test Suite: Migrated tests to testify/suite for better grouping and setup logic.
• New Test Suite: Created pkg/toolsets/netedge/suite_test.go to house the shared NetEdgeTestSuite.

This addresses feedback from @matzew regarding test grouping and client usage.

Related PRs:

• NE-2449: add netedge tool and get_coredns_config #131 (Introduced get_coredns_config)
• NE-2448: Add get_service_endpoints tool for NIDS troubleshooting #144 (Pattern for DynamicClient and testify/suite)

[bentito]

@matzew I think this one is all set

[bentito]

/assign @matzew

[bentito]

@matzew I think re-review, when you can thanks

[matzew]

/override "Konflux kflux-prd-rh02 / openshift-mcp-server-on-pull-request"

[matzew]

Note that you may need to `git add --force` ignored files in the vendor/ dir.
Unregistering from: subscription.rhsm.redhat.com:443/subscription
System has been unregistered.

something in the Red Hat Konflux / openshift-mcp-server-on-pull-request report.. 🤔

[matzew]

/lgtm
/approve

[openshift-ci]

@matzew: Overrode contexts on behalf of matzew: Konflux kflux-prd-rh02 / openshift-mcp-server-on-pull-request

Details

In response to this:

/override "Konflux kflux-prd-rh02 / openshift-mcp-server-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b6fb1e79-87e1-41a9-b5c6-a20da5eaa49b

📥 Commits

Reviewing files that changed from the base of the PR and between 2d1704d and f6c39c9.

📒 Files selected for processing (2)

• pkg/toolsets/netedge/coredns.go
• pkg/toolsets/netedge/coredns_test.go

---

Walkthrough

This change refactors DNS configuration retrieval from controller-runtime typed clients to Kubernetes dynamic clients, replacing structured ConfigMap handling with unstructured data access and adding error handling for missing data.

Changes

Cohort / File(s)	Summary
Core DNS Configuration Client Refactoring pkg/toolsets/netedge/coredns.go	Replaced controller-runtime client with dynamic client for ConfigMap retrieval. Switched from typed ConfigMap (corev1.ConfigMap) to unstructured data access via NestedStringMap. Added error handling for missing data and parse failures. Updated imports accordingly (removed REST/controller-runtime dependencies, added metav1, unstructured, runtime/schema).
Test Suite Updates pkg/toolsets/netedge/coredns_test.go	Updated test setup to use dynamic fake client with runtime scheme instead of controller-runtime fake client. Added new test case "failure - data not found" to validate behavior when ConfigMap data is absent. Removed newClientFunc override and updated test harness to wire dynamic client via s.SetDynamicClient.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[matzew]

/override "Konflux kflux-prd-rh02 / openshift-mcp-server-on-pull-request"

[openshift-ci]

@matzew: Overrode contexts on behalf of matzew: Konflux kflux-prd-rh02 / openshift-mcp-server-on-pull-request

Details

In response to this:

/override "Konflux kflux-prd-rh02 / openshift-mcp-server-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[matzew]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bentito, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@bentito: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@bentito: An error was encountered searching for bug NE-2449 on the Jira server at https://issues.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

request failed. Please analyze the request body for more details. Status code: 403:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

This PR refactors the get_coredns_config tool introduced in #131 to align with the patterns established in #144.

Changes:

• Dynamic Client: Switched from controller-runtime client to DynamicClient for consistency with inspect_route.
• Test Suite: Migrated tests to testify/suite for better grouping and setup logic.
• New Test Suite: Created pkg/toolsets/netedge/suite_test.go to house the shared NetEdgeTestSuite.

This addresses feedback from @matzew regarding test grouping and client usage.

Related PRs:

• NE-2449: add netedge tool and get_coredns_config #131 (Introduced get_coredns_config)
• NE-2448: Add get_service_endpoints tool for NIDS troubleshooting #144 (Pattern for DynamicClient and testify/suite)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@bentito: This pull request explicitly references no jira issue.

Details

In response to this:

This PR refactors the get_coredns_config tool introduced in #131 to align with the patterns established in #144.

Changes:

• Dynamic Client: Switched from controller-runtime client to DynamicClient for consistency with inspect_route.
• Test Suite: Migrated tests to testify/suite for better grouping and setup logic.
• New Test Suite: Created pkg/toolsets/netedge/suite_test.go to house the shared NetEdgeTestSuite.

This addresses feedback from @matzew regarding test grouping and client usage.

Related PRs:

• NE-2449: add netedge tool and get_coredns_config #131 (Introduced get_coredns_config)
• NE-2448: Add get_service_endpoints tool for NIDS troubleshooting #144 (Pattern for DynamicClient and testify/suite)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.