Skip to content

Backup SCC of Pod (#376)#387

Open
weshayutin wants to merge 1 commit intoopenshift:oadp-1.6from
weshayutin:backupsccoadp16
Open

Backup SCC of Pod (#376)#387
weshayutin wants to merge 1 commit intoopenshift:oadp-1.6from
weshayutin:backupsccoadp16

Conversation

@weshayutin
Copy link
Copy Markdown
Contributor

@weshayutin weshayutin commented Mar 25, 2026

CP: of #376
https://redhat.atlassian.net/browse/OADP-7513

  • backup SCC of pod
  • resolve remaining uncovered lines
  • empty group from gvk, check expected identifiers
  • skip lookup if scc annotation is empty
  • clarify test message
  • fix nit error =nil, remove unused security client
  • fix security client naming in clients doesn't match others

* backup SCC of pod

Signed-off-by: MICHAEL FRUCHTMAN <msfrucht@us.ibm.com>

* resolve remaining uncovered lines

Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com>

* empty group from gvk, check expected identifiers

Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com>

* skip lookup if scc annotation is empty

Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com>

* clarify test message

Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com>

* fix nit error =nil, remove unused security client

Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com>

* fix security client naming in clients doesn't match others

Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com>

---------

Signed-off-by: MICHAEL FRUCHTMAN <msfrucht@us.ibm.com>
Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b3d4ad16-3472-4d12-951a-b1864051b445

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@weshayutin
Copy link
Copy Markdown
Contributor Author

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 25, 2026

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants