Conversation
* backup SCC of pod Signed-off-by: MICHAEL FRUCHTMAN <msfrucht@us.ibm.com> * resolve remaining uncovered lines Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com> * empty group from gvk, check expected identifiers Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com> * skip lookup if scc annotation is empty Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com> * clarify test message Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com> * fix nit error =nil, remove unused security client Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com> * fix security client naming in clients doesn't match others Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com> --------- Signed-off-by: MICHAEL FRUCHTMAN <msfrucht@us.ibm.com> Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@weshayutin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CP: of #376
https://redhat.atlassian.net/browse/OADP-7513