Skip to content

OCPBUGS-77023: Fast track shouldn't happen when firmware update is in progress #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hroyrh wants to merge 1 commit into
base: release-4.21
Choose a base branch
from
Open

OCPBUGS-77023: Fast track shouldn't happen when firmware update is in progress #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ironic/conductor/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,7 +1205,11 @@ def fast_track_able(task):
and task.node.last_error is None
# NOTE(dtantsur): Fast track makes zero sense for servicing and
# may prevent normal clean-up from happening.
and task.node.provision_state not in states.SERVICING_STATES)
and task.node.provision_state not in states.SERVICING_STATES
# NOTE: Firmware updates require proper cleanup (e.g., virtual
# media ejection) and should not use fast-track.
and not task.node.driver_internal_info.get('redfish_fw_updates')
and not task.node.driver_internal_info.get('firmware_updates'))


def value_within_timeout(value, timeout):
Expand Down
16 changes: 16 additions & 0 deletions ironic/tests/unit/conductor/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2537,6 +2537,22 @@ def test_is_fast_track_not_in_servicing(self, mock_get_power):
task.node.provision_state = states.SERVICING
self.assertFalse(conductor_utils.is_fast_track(task))

def test_is_fast_track_redfish_fw_updates(self, mock_get_power):
mock_get_power.return_value = states.POWER_ON
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
task.node.set_driver_internal_info('redfish_fw_updates',
[{'url': 'http://test'}])
self.assertFalse(conductor_utils.is_fast_track(task))

def test_is_fast_track_firmware_updates(self, mock_get_power):
mock_get_power.return_value = states.POWER_ON
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
task.node.set_driver_internal_info('firmware_updates',
[{'url': 'http://test'}])
self.assertFalse(conductor_utils.is_fast_track(task))


class GetNodeNextStepsTestCase(db_base.DbTestCase):
def setUp(self):
Expand Down