OCPBUGS-77179: Synchronize From Upstream Repositories by openshift-bot · Pull Request #1260 · openshift/operator-framework-olm

openshift-bot · 2026-03-19T00:04:41Z

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date	Commit	Author	Message
2026-03-18 13:38:42	operator-framework/operator-lifecycle-manager@778ed49	Jian Zhang	Fix nil pointer dereference in sortUnpackJobs when sorting non-failed jobs (#3793)
2026-03-18 14:43:26	operator-framework/operator-lifecycle-manager@59732f5	dependabot[bot]	🌱 Bump golang.org/x/net from 0.51.0 to 0.52.0 (#3797)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-framework

openshift-ci-robot · 2026-03-19T00:04:48Z

@openshift-bot: This pull request explicitly references no jira issue.

Details

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message

2026-03-18 13:38:42 operator-framework/operator-lifecycle-manager@778ed49 Jian Zhang Fix nil pointer dereference in sortUnpackJobs when sorting non-failed jobs (#3793)

2026-03-18 14:43:26 operator-framework/operator-lifecycle-manager@59732f5 dependabot[bot] 🌱 Bump golang.org/x/net from 0.51.0 to 0.52.0 (#3797)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-framework

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-03-19T00:04:49Z

@openshift-bot: GitHub didn't allow me to request PR reviews from the following users: openshift/openshift-team-operator-framework.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message

2026-03-18 13:38:42 operator-framework/operator-lifecycle-manager@778ed49 Jian Zhang Fix nil pointer dereference in sortUnpackJobs when sorting non-failed jobs (#3793)

2026-03-18 14:43:26 operator-framework/operator-lifecycle-manager@59732f5 dependabot[bot] 🌱 Bump golang.org/x/net from 0.51.0 to 0.52.0 (#3797)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-framework

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

coderabbitai · 2026-03-19T00:05:04Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 567bd2fa-1502-4ab4-b2ec-3daa38db9e37

📥 Commits

Reviewing files that changed from the base of the PR and between 0420971 and 6087955.

⛔ Files ignored due to path filters (38)

go.sum is excluded by !**/*.sum
staging/operator-lifecycle-manager/go.sum is excluded by !**/*.sum
vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/controller/bundle/bundle_unpacker.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/http2/http2.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/http2/server.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/http2/transport.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/http2/writesched.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/http2/writesched_priority_rfc7540.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/http2/writesched_random.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/sys/cpu/asm_darwin_arm64_gc.s is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/sys/cpu/cpu_arm64.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/sys/cpu/cpu_darwin_arm64.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/sys/cpu/cpu_darwin_arm64_other.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/sys/cpu/cpu_gccgo_arm64.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/sys/cpu/cpu_other_arm64.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/sys/cpu/syscall_darwin_arm64_gc.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/sys/plan9/syscall_plan9.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/sys/unix/ztypes_linux.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/sys/windows/aliases.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/sys/windows/registry/key.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/sys/windows/syscall_windows.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/cursor.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/inspector.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/iter.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/packages/packages.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/types/objectpath/objectpath.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/internal/aliases/aliases.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/internal/aliases/aliases_go122.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/internal/event/core/event.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/internal/event/keys/keys.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/internal/event/label/label.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/internal/gcimporter/iexport.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/internal/gcimporter/iimport.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/internal/gcimporter/ureader_yes.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/internal/stdlib/deps.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/internal/typeparams/free.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/internal/typesinternal/types.go is excluded by !vendor/**, !**/vendor/**
vendor/modules.txt is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (4)

go.mod
staging/operator-lifecycle-manager/go.mod
staging/operator-lifecycle-manager/pkg/controller/bundle/bundle_unpacker.go
staging/operator-lifecycle-manager/pkg/controller/bundle/bundle_unpacker_test.go

✅ Files skipped from review due to trivial changes (2)

go.mod
staging/operator-lifecycle-manager/go.mod

🚧 Files skipped from review as they are similar to previous changes (2)

staging/operator-lifecycle-manager/pkg/controller/bundle/bundle_unpacker_test.go
staging/operator-lifecycle-manager/pkg/controller/bundle/bundle_unpacker.go

Walkthrough

Updated indirect Go module dependency versions in root and staging go.mod files. Added a nil-check fallback in sortUnpackJobs to use Job CreationTimestamp when JobFailed conditions are absent, and expanded tests to cover ordering of multiple non-failed jobs by creation time.

Changes

Cohort / File(s)	Summary
Dependency updates `go.mod`, `staging/operator-lifecycle-manager/go.mod`	Bumped indirect golang.org/x/* module versions: `crypto` v0.48.0→v0.49.0, `net` v0.51.0→v0.52.0, `sys` v0.41.0→v0.42.0, `term` v0.40.0→v0.41.0, `text` v0.34.0→v0.35.0, `tools` v0.41.0→v0.42.0. No code logic changes.
Bundle unpacker logic & tests `staging/operator-lifecycle-manager/pkg/controller/bundle/bundle_unpacker.go`, `staging/operator-lifecycle-manager/pkg/controller/bundle/bundle_unpacker_test.go`	Added nil-check in `sortUnpackJobs` to fall back to comparing `CreationTimestamp` when `JobFailed` conditions are absent; updated tests to set `CreationTimestamp` on test jobs and added a case asserting multiple non-failed jobs are sorted by creation time.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-03-19T00:05:15Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-03-19T00:05:15Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jianzhangbjz · 2026-03-19T00:53:56Z

/retitle OCPBUGS-77179: Synchronize From Upstream Repositories

openshift-ci-robot · 2026-03-19T00:54:05Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-77179, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message

2026-03-18 13:38:42 operator-framework/operator-lifecycle-manager@778ed49 Jian Zhang Fix nil pointer dereference in sortUnpackJobs when sorting non-failed jobs (#3793)

2026-03-18 14:43:26 operator-framework/operator-lifecycle-manager@59732f5 dependabot[bot] 🌱 Bump golang.org/x/net from 0.51.0 to 0.52.0 (#3797)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-framework

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2026-03-19T00:54:11Z

/retest-required

jianzhangbjz · 2026-03-19T00:55:28Z

/jira refresh

openshift-ci-robot · 2026-03-19T00:55:37Z

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-77179, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

… jobs (#3793) Signed-off-by: Jian Zhang <jiazha@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 778ed4909930934bf84f5a3a34172e5822e84bdc

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.51.0 to 0.52.0. - [Commits](golang/net@v0.51.0...v0.52.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.52.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 59732f585fce93e85dac7c1ca0d28788a36eb503

openshift-ci-robot · 2026-03-20T00:03:58Z

@openshift-bot: This pull request explicitly references no jira issue.

Details

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message

2026-03-18 13:38:42 operator-framework/operator-lifecycle-manager@778ed49 Jian Zhang Fix nil pointer dereference in sortUnpackJobs when sorting non-failed jobs (#3793)

2026-03-18 14:43:26 operator-framework/operator-lifecycle-manager@59732f5 dependabot[bot] 🌱 Bump golang.org/x/net from 0.51.0 to 0.52.0 (#3797)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-framework

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-03-20T00:04:00Z

New changes are detected. LGTM label has been removed.

jianzhangbjz · 2026-03-20T00:28:00Z

/retitle OCPBUGS-77179: Synchronize From Upstream Repositories

openshift-ci-robot · 2026-03-20T00:28:09Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-77179, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

Details

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message

2026-03-18 13:38:42 operator-framework/operator-lifecycle-manager@778ed49 Jian Zhang Fix nil pointer dereference in sortUnpackJobs when sorting non-failed jobs (#3793)

2026-03-18 14:43:26 operator-framework/operator-lifecycle-manager@59732f5 dependabot[bot] 🌱 Bump golang.org/x/net from 0.51.0 to 0.52.0 (#3797)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-framework

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2026-03-20T00:28:18Z

/retest-required

jianzhangbjz · 2026-03-20T08:03:39Z

/retest-required
/verified by @jianzhangbjz

openshift-ci-robot · 2026-03-20T08:03:58Z

@jianzhangbjz: This PR has been marked as verified by @jianzhangbjz.

Details

In response to this:

/retest-required
/verified by @jianzhangbjz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2026-03-20T08:04:03Z

e2e-aws-upgrade-ovn-single-node test passed.

openshift-ci · 2026-03-20T08:27:06Z

@openshift-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Mar 19, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2026

openshift-ci bot changed the title ~~NO-ISSUE: Synchronize From Upstream Repositories~~ OCPBUGS-77179: Synchronize From Upstream Repositories Mar 19, 2026

openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Mar 19, 2026

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 19, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 19, 2026

jianzhangbjz and others added 2 commits March 20, 2026 00:03

Fix nil pointer dereference in sortUnpackJobs when sorting non-failed…

451d6c7

… jobs (#3793) Signed-off-by: Jian Zhang <jiazha@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 778ed4909930934bf84f5a3a34172e5822e84bdc

openshift-bot changed the title ~~OCPBUGS-77179: Synchronize From Upstream Repositories~~ NO-ISSUE: Synchronize From Upstream Repositories Mar 20, 2026

openshift-bot force-pushed the synchronize-upstream branch from 0420971 to 6087955 Compare March 20, 2026 00:03

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2026

openshift-ci-robot removed the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Mar 20, 2026

openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 20, 2026

openshift-ci bot changed the title ~~NO-ISSUE: Synchronize From Upstream Repositories~~ OCPBUGS-77179: Synchronize From Upstream Repositories Mar 20, 2026

openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Mar 20, 2026

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 20, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 20, 2026

Conversation

openshift-bot commented Mar 19, 2026

Uh oh!

openshift-ci-robot commented Mar 19, 2026

Uh oh!

openshift-ci bot commented Mar 19, 2026

Uh oh!

coderabbitai bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci bot commented Mar 19, 2026

Uh oh!

openshift-ci bot commented Mar 19, 2026

Uh oh!

jianzhangbjz commented Mar 19, 2026

Uh oh!

openshift-ci-robot commented Mar 19, 2026

Uh oh!

jianzhangbjz commented Mar 19, 2026

Uh oh!

jianzhangbjz commented Mar 19, 2026

Uh oh!

openshift-ci-robot commented Mar 19, 2026

Uh oh!

openshift-ci-robot commented Mar 20, 2026

Uh oh!

openshift-ci bot commented Mar 20, 2026

Uh oh!

jianzhangbjz commented Mar 20, 2026

Uh oh!

openshift-ci-robot commented Mar 20, 2026

Uh oh!

jianzhangbjz commented Mar 20, 2026

Uh oh!

jianzhangbjz commented Mar 20, 2026

Uh oh!

openshift-ci-robot commented Mar 20, 2026

Uh oh!

jianzhangbjz commented Mar 20, 2026

Uh oh!

openshift-ci bot commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Mar 19, 2026 •

edited

Loading