NO-JIRA: Tolerate events during the vSphere CSI driver removal test by jsafrane · Pull Request #31124 · openshift/origin

jsafrane · 2026-05-05T11:58:26Z

Test "vSphere CSI Driver Operator Removal" un-installs the CSI driver + installs it back. I.e. a DaemonSet and two Deployment are deleted + re-created with many events like "Created pod: vmware-vsphere-csi-driver-node-tkl25"

See openshift/vmware-vsphere-csi-driver-operator#337 that adds the test + a rehearsal result

Summary by CodeRabbit

Tests
- Broadened detection of vSphere CSI-related E2E test intervals to include additional configuration and operator-removal scenarios, improving recognition of relevant test overlaps.
- Added interval-overlap detection and a storage-specific exception path to better handle upgrade/test timing edge cases in monitoring tests.

openshift-merge-bot · 2026-05-05T11:58:29Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-05-05T11:58:30Z

@jsafrane: This pull request explicitly references no jira issue.

Details

In response to this:

Test "vSphere CSI Driver Operator Removal" un-installs the CSI driver + installs it back. I.e. a DaemonSet and two Deployment with many events like "Created pod: vmware-vsphere-csi-driver-node-tkl25"

See openshift/vmware-vsphere-csi-driver-operator#337 that adds the test + a rehearsal result

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-05T11:58:52Z

Caution

Review failed

The head commit changed during the review from e6010e0 to 848ee43.

Walkthrough

Adds broader vSphere E2E test name matching and a helper to detect when an upgrade-event interval overlaps E2E test intervals; wires that helper into a storage-specific exception path used during operator state transition checks.

Changes

vSphere E2E Interval Detection and Overlap Handling

Layer / File(s)	Summary
Pattern Matching `pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go`	`newVsphereConfigurationTestsRollOutTooOftenEventMatcher` now treats intervals with `Source == monitorapi.SourceE2ETest` as vSphere configuration tests when their `LocatorE2ETestKey` contains either `"snapshot options in clusterCSIDriver"` or `"vSphere CSI Driver Operator Removal"` (previously only the first substring was matched).
Overlap Helper `pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go`	Adds `intervalOverlapsE2ETest(e2eIntervals, eventInterval, testNameSubstring)` to check whether an event interval overlaps any E2E test interval whose locator-derived name contains `testNameSubstring` (ignores Info-level entries).
Integration / Exception Wiring `pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go`	Initializes `e2eEventIntervals` in `testStableSystemOperatorStateTransitions`, renames the exception callback parameter to `eventInterval`, and uses `intervalOverlapsE2ETest` in the `storage` operator exception branch to detect overlap with the `"vSphere CSI Driver Operator Removal"` test and return a specific explanatory message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and specifically describes the main change: adding tolerance for events during the vSphere CSI driver removal test, which aligns with both file modifications.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only helper/library files (not Ginkgo test files). No Ginkgo test declarations are present or modified. Test name references are static strings used for matching only.
Test Structure And Quality	✅ Passed	Not applicable. The PR modifies monitor test helper files, not Ginkgo test code. No Ginkgo test definitions found.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. The changes are limited to library files that update event matching and exception handling logic. The test being referenced is in a separate repository.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. Changes are only to monitor test utilities and exception handlers. No new tests are defined, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR changes only monitoring/testing utilities (event matchers and operator state validation), not deployment manifests, operators, or controllers. No scheduling constraints introduced.
Ote Binary Stdout Contract	✅ Passed	Modifies only library packages. Changes add helper functions without process-level code. No stdout writes detected.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests. It modifies utility library code (event matchers and test analysis functions) to handle events from existing e2e tests. Check not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-05-05T11:58:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign mkowalski for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-05-05T12:00:25Z

@jsafrane: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/feb5b540-4879-11f1-9b84-0bd24eaf093f-0

openshift-merge-bot · 2026-05-05T12:27:01Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-ci · 2026-05-06T10:27:57Z

@jsafrane: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/37759370-4936-11f1-9e56-9cae5cc88990-0

openshift-ci · 2026-05-06T13:51:28Z

@jsafrane: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/96558910-4952-11f1-97b0-fb3ae878c0e7-0

openshift-ci · 2026-05-06T16:30:10Z

@jsafrane: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d510caf0-4968-11f1-8c7c-279887907322-0

openshift-merge-bot · 2026-05-06T17:02:19Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-ci · 2026-05-11T15:41:08Z

@jsafrane: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d169c100-4d4f-11f1-9ff8-0e8746f8c833-0

openshift-merge-bot · 2026-05-11T16:16:01Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-ci · 2026-05-11T20:23:19Z

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-csi	`6bb760b`	link	true	`/test e2e-gcp-csi`
ci/prow/e2e-gcp-ovn	`6bb760b`	link	true	`/test e2e-gcp-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci · 2026-05-13T12:41:07Z

@jsafrane: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/004dd590-4ec9-11f1-993b-173c43a0464e-0

Test "vSphere CSI Driver Operator Removal" un-installs the CSI driver + installs it back. I.e. a DaemonSet and two Deployments will generate many events like "Created pod: vmware-vsphere-csi-driver-node-tkl25"

…test The test "vSphere CSI Driver Operator Removal should successfully remove and restore storage resources" removes the vSphere CSI driver and re-installs it back. During that test the Storage may become temporarily Available: false. When adding it back, the desired cluster configuration is that is that the driver should be available, but it takes a while to reach that state.

openshift-ci · 2026-06-26T14:39:32Z

@jsafrane: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d57705f0-716c-11f1-83bf-d37e034c8961-0

openshift-merge-bot · 2026-06-26T15:05:47Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2026

openshift-ci Bot requested review from deads2k and p0lyn0mial May 5, 2026 11:59

jsafrane mentioned this pull request May 5, 2026

NO-JIRA: Move "managementState: Removed" test to OTE openshift/vmware-vsphere-csi-driver-operator#337

Open

coderabbitai Bot approved these changes May 5, 2026

View reviewed changes

openshift-merge-bot Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 5, 2026

jsafrane force-pushed the add-driver=removal-test-exception branch from d1d7137 to 6bb760b Compare May 11, 2026 15:42

jsafrane force-pushed the add-driver=removal-test-exception branch from 6bb760b to e6010e0 Compare June 26, 2026 14:34

jsafrane added 2 commits June 26, 2026 16:36

Tolerate events during the vSphere CSI driver removal test

4dfc5ad

Test "vSphere CSI Driver Operator Removal" un-installs the CSI driver + installs it back. I.e. a DaemonSet and two Deployments will generate many events like "Created pod: vmware-vsphere-csi-driver-node-tkl25"

jsafrane force-pushed the add-driver=removal-test-exception branch from e6010e0 to 848ee43 Compare June 26, 2026 14:37

Uh oh!

Conversation

jsafrane commented May 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented May 5, 2026

Uh oh!

openshift-ci-robot commented May 5, 2026

Uh oh!

coderabbitai Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning)

Review ran into problems

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

openshift-merge-bot Bot commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 6, 2026

Uh oh!

openshift-ci Bot commented May 6, 2026

Uh oh!

openshift-ci Bot commented May 6, 2026

Uh oh!

openshift-merge-bot Bot commented May 6, 2026

Uh oh!

openshift-ci Bot commented May 11, 2026

Uh oh!

openshift-merge-bot Bot commented May 11, 2026

Uh oh!

openshift-ci Bot commented May 11, 2026

Uh oh!

openshift-ci Bot commented May 13, 2026

Uh oh!

openshift-ci Bot commented Jun 26, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jsafrane commented May 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 5, 2026 •

edited

Loading