-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Fix longrunning suite for node test cases #31339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ngopalak-redhat
wants to merge
7
commits into
openshift:main
Choose a base branch
from
ngopalak-redhat:ngopalak/fix_long_running_timeout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+457
−215
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
eab34fd
Fix longrunning test case Exec timeout
ngopalak-redhat 8160a00
Fix longrunning test case Exec timeout
ngopalak-redhat 01a5976
Fix longrunning test case Exec timeout
ngopalak-redhat 33b1251
Fix longrunning test case test timeout
ngopalak-redhat 6c52c04
Fix longrunning test case test timeout
ngopalak-redhat 5c7b479
Fix longrunning test case test timeout
ngopalak-redhat cf3cd25
Fix longrunning test case test timeout
ngopalak-redhat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Don't swallow rollback failures in this ordered cleanup.
This
DeferCleanupdrops both thedeleteKCandwaitForMCPerrors, so Case 4 can leave the worker pool mid-rollout and still pass cleanup. In ang.Orderedsuite, that leaks mutated cluster state into later cases.Suggested fix
g.DeferCleanup(func() { - _ = deleteKC(oc, kcName) - _ = waitForMCP(ctx, mcClient, "worker", 15*time.Minute) + if err := deleteKC(oc, kcName); err != nil { + framework.Failf("cleanup: failed to delete KubeletConfig %s: %v", kcName, err) + } + if err := waitForMCP(ctx, mcClient, "worker", 15*time.Minute); err != nil { + framework.Failf("cleanup: worker MCP did not recover after deleting %s: %v", kcName, err) + } })As per path instructions,
**/*.go: Never ignore error returns.📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Path instructions