AGENT-1429: Add SNO IPV4 periodic job for OVE#79640
Conversation
|
@pawanpinjarkar: This pull request references AGENT-1429 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughA new periodic CI test job, e2e-agent-sno-ipv4-iso-no-registry-techpreview, is added to the nightly-5.0 release config; it targets equinix-ocp-metal, runs every 8 hours, and sets DEVSCRIPTS_CONFIG for SNO_IPV4, ISO no-registry, AGENT_PLATFORM_TYPE=none, and TechPreviewNoUpgrade. ChangesNew SNO IPv4 ISO no-registry TechPreview CI job
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/cc @andfasano @bfournie |
|
/depends on openshift-metal3/dev-scripts#1897 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`:
- Around line 2183-2196: You added a new CI job definition (as:
e2e-agent-sno-ipv4-iso-no-registry-techpreview with workflow
agent-e2e-generic-conformance-iso-no-registry) in ci-operator/config; run the
repository's downstream artifact generator by executing make update, commit the
modified generated files produced by that command (the ci-operator/ and/or
core-services/openshift-*-generated YAMLs) and include those diffs in this PR so
the new test is reflected in the generated artifacts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2d8ff894-6ad3-439d-a1a7-5bc53a0aae2e
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/release/openshift-release-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
04a2ac0 to
6708f58
Compare
|
/retest-required |
|
/pj-rehearse |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Its weird the same config works fine locally but rehearsals are failing |
|
/lgtm |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
It looks like the tests are running with an older version of dev-scripts without openshift-metal3/dev-scripts#1897 |
|
/retest |
yes and not sure why |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
61f1d59 to
86c426d
Compare
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Actionable comments posted: 0 |
…archTuningOperator, and it will scale up any machine available. Some times, amd64 ones are not available, and then arm64 are used. The default behavior is always send to amd64, but when they are not available, other is utilized.
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
Actionable comments posted: 0 |
|
/lgtm |
|
/approve |
1 similar comment
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, pawanpinjarkar, petr-muller, xueqzhan, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Retrying rehearsal, since openshift/machine-config-operator#6109 just landed /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview |
|
@andfasano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Last rehearsal seems to be stuck at |
|
@pawanpinjarkar: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add a new periodic job for SNO IPV4 OVE
Summary by CodeRabbit
This PR updates the OpenShift release CI configuration in the openshift/release repository to add a new periodic CI test for the assisted-installer (agent) flow targeting Single Node OpenShift (SNO) IPv4.
Practical changes:
Operational notes: