Skip to content

AGENT-1429: Add SNO IPV4 periodic job for OVE#79640

Open
pawanpinjarkar wants to merge 2 commits into
openshift:mainfrom
pawanpinjarkar:add-sno-ipv4-4-ove
Open

AGENT-1429: Add SNO IPV4 periodic job for OVE#79640
pawanpinjarkar wants to merge 2 commits into
openshift:mainfrom
pawanpinjarkar:add-sno-ipv4-4-ove

Conversation

@pawanpinjarkar
Copy link
Copy Markdown
Contributor

@pawanpinjarkar pawanpinjarkar commented May 21, 2026

Add a new periodic job for SNO IPV4 OVE

Summary by CodeRabbit

This PR updates the OpenShift release CI configuration in the openshift/release repository to add a new periodic CI test for the assisted-installer (agent) flow targeting Single Node OpenShift (SNO) IPv4.

Practical changes:

  • Adds a new scheduled test job entry to ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml:
    • name/as: e2e-agent-sno-ipv4-iso-no-registry-techpreview
    • schedule: cron: "0 */8 * * *" (every 8 hours)
    • cluster_profile: equinix-ocp-metal
    • capability: intranet
    • node_architecture: amd64
    • workflow: agent-e2e-generic-conformance-iso-no-registry
    • DEVSCRIPTS_CONFIG: configures SNO_IPV4 agent scenario with BOOT=ISO_NO_REGISTRY, AGENT_CLEANUP_ISO_BUILDER_CACHE_LOCAL_DEV=true, AGENT_PLATFORM_TYPE=none, FEATURE_SET=TechPreviewNoUpgrade

Operational notes:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 21, 2026

@pawanpinjarkar: This pull request references AGENT-1429 which is a valid jira issue.

Details

In response to this:

Add a new periodic job for SNO IPV4 OVE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d65bdf03-52ad-4b39-9f90-4e3696f7cc52

📥 Commits

Reviewing files that changed from the base of the PR and between 86c426d and 4a183a2.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml

Walkthrough

A new periodic CI test job, e2e-agent-sno-ipv4-iso-no-registry-techpreview, is added to the nightly-5.0 release config; it targets equinix-ocp-metal, runs every 8 hours, and sets DEVSCRIPTS_CONFIG for SNO_IPV4, ISO no-registry, AGENT_PLATFORM_TYPE=none, and TechPreviewNoUpgrade.

Changes

New SNO IPv4 ISO no-registry TechPreview CI job

Layer / File(s) Summary
New SNO IPv4 ISO no-registry TechPreview job definition
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
Inserted a new test job entry e2e-agent-sno-ipv4-iso-no-registry-techpreview with cluster profile equinix-ocp-metal, intranet capability, cron: 0 */8 * * *, agent-e2e-generic-conformance-iso-no-registry workflow, and DEVSCRIPTS_CONFIG values: SNO_IPV4 scenario, ISO no-registry boot mode, AGENT_CLEANUP_ISO_BUILDER_CACHE_LOCAL_DEV=true, AGENT_PLATFORM_TYPE=none, and FEATURE_SET=TechPreviewNoUpgrade.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • openshift/release#79783: Both PRs modify the nightly-5.0 YAML by adding/updating *iso-no-registry* TechPreview agent E2E job configurations.

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

  • wking
  • bfournie
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title directly references the main change: adding a new SNO IPV4 periodic job, which matches the changeset that adds the e2e-agent-sno-ipv4-iso-no-registry-techpreview test job.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only a YAML CI config file with no Ginkgo test code. The check for stable test names applies to test titles (It(), Describe(), etc.), which are not present in this PR.
Test Structure And Quality ✅ Passed This PR only modifies CI configuration YAML, not Ginkgo test code. The custom check is not applicable as no Go test files are added.
Microshift Test Compatibility ✅ Passed PR only adds CI configuration (YAML) to schedule an existing workflow in openshift/release repository; no new Ginkgo e2e test code is added, so MicroShift API compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies CI configuration (YAML), not test source code. The custom check applies to new Ginkgo tests, which are not present in this PR.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds only a CI-Operator test job configuration, not deployment manifests, operator code, or controllers. Custom check applies only to those categories and does not apply here.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI configuration and documentation; no source code changes. OTE Binary Stdout Contract check applies only to test source code, not CI config files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds only CI configuration (YAML), not new Ginkgo test code. Check applies only when new Ginkgo e2e tests are added; no .go test files with Ginkgo patterns were added.
No-Weak-Crypto ✅ Passed PR adds only CI test configuration in YAML format with no cryptographic code, weak cipher usage, custom crypto implementations, or insecure secret/token comparisons.
Container-Privileges ✅ Passed PR adds a ci-operator configuration file entry, not a Kubernetes manifest. No container security specifications (privileged, hostPID, hostNetwork, etc.) are present.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only configuration flags and feature specifications with no passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data exposed in the new job definition.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from petr-muller and wking May 21, 2026 23:15
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/cc @andfasano @bfournie

@openshift-ci openshift-ci Bot requested review from andfasano and bfournie May 21, 2026 23:16
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/depends on openshift-metal3/dev-scripts#1897

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`:
- Around line 2183-2196: You added a new CI job definition (as:
e2e-agent-sno-ipv4-iso-no-registry-techpreview with workflow
agent-e2e-generic-conformance-iso-no-registry) in ci-operator/config; run the
repository's downstream artifact generator by executing make update, commit the
modified generated files produced by that command (the ci-operator/ and/or
core-services/openshift-*-generated YAMLs) and include those diffs in this PR so
the new test is reflected in the generated artifacts.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2d8ff894-6ad3-439d-a1a7-5bc53a0aae2e

📥 Commits

Reviewing files that changed from the base of the PR and between bc36c6c and 04a2ac0.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml

Comment thread ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml Outdated
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/retest-required

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

Its weird the same config works fine locally but rehearsals are failing

@bfournie
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2026
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@zaneb
Copy link
Copy Markdown
Member

zaneb commented May 28, 2026

It looks like the tests are running with an older version of dev-scripts without openshift-metal3/dev-scripts#1897

@andfasano
Copy link
Copy Markdown
Contributor

/retest

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

It looks like the tests are running with an older version of dev-scripts without openshift-metal3/dev-scripts#1897

yes and not sure why

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

…archTuningOperator, and it will scale up any machine available. Some times, amd64 ones are not available, and then arm64 are used.

The default behavior is always send to amd64, but when they are not available, other is utilized.
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@pawanpinjarkar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@zaneb
Copy link
Copy Markdown
Member

zaneb commented May 28, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2026
@zaneb
Copy link
Copy Markdown
Member

zaneb commented May 28, 2026

/approve

1 similar comment
@petr-muller
Copy link
Copy Markdown
Member

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2026
@xueqzhan
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, pawanpinjarkar, petr-muller, xueqzhan, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andfasano
Copy link
Copy Markdown
Contributor

Retrying rehearsal, since openshift/machine-config-operator#6109 just landed

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@andfasano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

Last rehearsal seems to be stuck at Custom Manifests step. Retrying.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 3, 2026

@pawanpinjarkar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview 4a183a2 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants