fix(hypershift/gcp): unpin CAPG image override (GCP-426)

[cristianoveiga]

Summary

Removes the pinned CAPG image override (`hypershift.openshift.io/capi-provider-gcp-image`) from the `hypershift-gcp-create` chain.

Root Cause

The OCP payload CAPG image is built against CAPI v1.11+, which watches `cluster.x-k8s.io/v1beta2` core resources (Machines, Clusters, MachineSets). Before openshift/hypershift#8594 (CAPI 1.11 upgrade), HyperShift's core CAPI CRDs only served `v1beta1`, causing the CAPG controller to CrashLoopBackOff. The image was pinned to an older build as a workaround.

PR #8594 has since merged, and the core CAPI CRDs now serve both `v1beta1` and `v1beta2` via a conversion webhook. The pin is no longer needed.

Test plan

• Rehearsal job `e2e-v2-gke` passed without the pinned image (run)

Closes https://redhat.atlassian.net/browse/GCP-426

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Walkthrough

This PR removes the CAPG image override configuration from the HyperShift GCP cluster creation step. It eliminates the CAPG_IMAGE environment variable definition and the corresponding annotation argument, allowing the cluster creation to use default CAPG image selection instead of an explicitly pinned digest.

Changes

CAPG image override removal

Layer / File(s)	Summary
CAPG image override removal from cluster creation ci-operator/step-registry/hypershift/gcp/create/hypershift-gcp-create-chain.yaml	Removes the CAPG_IMAGE variable definition (lines 43–48) and the hypershift.openshift.io/capi-provider-gcp-image annotation argument (line 77) from the HyperShift GCP cluster creation command, delegating image selection to default behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main change: removing a pinned CAPG image override in the HyperShift GCP configuration. It is concise, specific, and includes a reference to the issue (GCP-426).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only modifies a YAML CI step configuration file, not test code. No Ginkgo tests are present in the changes, making the test name stability check inapplicable.
Test Structure And Quality	✅ Passed	PR contains no Ginkgo test code. The custom check requiring Ginkgo test review is not applicable - the test files use standard Go testing.T patterns, not Ginkgo BDD-style tests.
Microshift Test Compatibility	✅ Passed	This PR does not add new Ginkgo e2e tests. It only modifies YAML step registry configuration to remove a CAPG image override from HyperShift GCP cluster creation workflow.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR; only YAML CI configuration is modified. The SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	CI step configuration file with no Kubernetes scheduling constraints. Check not applicable to this type of change.
Ote Binary Stdout Contract	✅ Passed	No OTE test binaries modified. PR changes YAML config and utility tools (gotest2junit, junitreport), not OTE test implementations.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR only modifies YAML step-registry configuration (hypershift-gcp-create-chain.yaml); no Ginkgo e2e test code was added, so the IPv6/disconnected compatibility check does not apply.
No-Weak-Crypto	✅ Passed	PR modifies only YAML infrastructure configuration; no weak crypto patterns (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB) found in file or changes.
Container-Privileges	✅ Passed	PR removes CAPG image override; no privileged container settings found in any modified files.
No-Sensitive-Data-In-Logs	✅ Passed	PR removes a CAPG_IMAGE variable containing an internal container image digest that would be logged due to set -x, reducing sensitive data exposure in CI logs.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cristianoveiga]

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-v2-gke

[openshift-merge-bot]

@cristianoveiga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[cristianoveiga]

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-v2-gke

[openshift-merge-bot]

@cristianoveiga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@cristianoveiga: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cristianoveiga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/hypershift/gcp/create/OWNERS [cblecker,cristianoveiga]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cblecker]

/pj-rehearse ack

[openshift-merge-bot]

@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.