feat(rhdh): align disconnected CATALOG_INDEX_IMAGE as single Gangway override#81128
feat(rhdh): align disconnected CATALOG_INDEX_IMAGE as single Gangway override#81128zdrapela wants to merge 1 commit into
Conversation
…override Replace three separate CATALOG_INDEX_REGISTRY/REPO/TAG Gangway override parameters with a single CATALOG_INDEX_IMAGE parameter, matching the pattern used by the connected helm/operator jobs. The rhdh repo's env_variables.sh handles splitting CATALOG_INDEX_IMAGE into registry/repo/tag components. Using the single-variable approach fixes the CI build verification flow where CATALOG_INDEX_IMAGE was never constructed from the three components and the handler's if-blocks never triggered. Changes: - commands.sh: export CATALOG_INDEX_IMAGE instead of 3 separate vars - helm ref.yaml: single MULTISTAGE_PARAM_OVERRIDE_CATALOG_INDEX_IMAGE - operator ref.yaml: same (commands.sh is a symlink to helm's) Assisted-by: OpenCode
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
WalkthroughThe PR replaces separate catalog index registry/repo/tag override parameters with a single catalog index image override in the nightly disconnected Helm and operator step references, and updates the shell script to export and consume ChangesCatalog index image override
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdrapela The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@zdrapela: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Replace three separate
CATALOG_INDEX_REGISTRY/REPO/TAGGangway override parameters with a singleCATALOG_INDEX_IMAGEparameter, matching the pattern used by the connected helm/operator jobs.The rhdh repo's
env_variables.shhandles splittingCATALOG_INDEX_IMAGEinto registry/repo/tag components. Using the single-variable approach fixes the CI build verification flow whereCATALOG_INDEX_IMAGEwas never constructed from the three components and the handler's if-blocks never triggered.Changes
commands.sh: exportCATALOG_INDEX_IMAGEinstead of 3 separate varsref.yaml: singleMULTISTAGE_PARAM_OVERRIDE_CATALOG_INDEX_IMAGEref.yaml: same (commands.sh is a symlink to helm's)Companion PR
redhat-developer/rhdh#5008
Summary by CodeRabbit
This change updates the disconnected RHDH Gangway CI configuration to pass the catalog index as a single
CATALOG_INDEX_IMAGEvalue instead of splitting it into registry, repo, and tag parts.Practically, this aligns the disconnected Helm and operator jobs with the connected-job pattern, so the CI environment now handles the catalog index image consistently and avoids the build verification issue caused by the old three-part override flow not triggering the expected env handling logic.