[Draft] - Testing compact installations after capabilities changes#81134
[Draft] - Testing compact installations after capabilities changes#81134miyadav wants to merge 2 commits into
Conversation
openshift-ci
Bot
added
the
do-not-merge/hold
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a new periodic CI config for cluster-version-operator on release 5.0, including build and release settings, default pod resources, and an ChangesRelease 5.0 periodic config
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse periodic-ci-openshift-cluster-version-operator-release-5.0-periodics-e2e-gcp-compact-install |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: miyadav The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-5.0__periodics.yaml`:
- Around line 32-33: The periodic job is hardcoding a specific CI pullspec in
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE instead of using the configured release
alias. Update the dependencies in the cluster-version-operator periodic config
to reference the ci-operator release alias from the existing releases section,
and remove the fixed
registry.build10.ci.openshift.org/ci-ln-llimy2k/release:latest value so the job
resolves the payload dynamically.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 359560c7-157e-4c40-be18-6a88435734f1
⛔ Files ignored due to path filters (3)
ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-release-5.0-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-release-5.0-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-release-5.0-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-5.0__periodics.yaml
| dependencies: | ||
| OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: registry.build10.ci.openshift.org/ci-ln-llimy2k/release:latest |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Use the ci-operator release alias here instead of a fixed CI pullspec.
Hardcoding registry.build10.ci.openshift.org/ci-ln-llimy2k/release:latest ties this periodic to one ephemeral CI namespace and bypasses the releases configuration above, so the job can start pulling the wrong payload or fail once that namespace is cleaned up.
Suggested fix
dependencies:
- OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: registry.build10.ci.openshift.org/ci-ln-llimy2k/release:latest
+ OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:latest📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| dependencies: | |
| OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: registry.build10.ci.openshift.org/ci-ln-llimy2k/release:latest | |
| dependencies: | |
| OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:latest |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-5.0__periodics.yaml`
around lines 32 - 33, The periodic job is hardcoding a specific CI pullspec in
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE instead of using the configured release
alias. Update the dependencies in the cluster-version-operator periodic config
to reference the ci-operator release alias from the existing releases section,
and remove the fixed
registry.build10.ci.openshift.org/ci-ln-llimy2k/release:latest value so the job
resolves the payload dynamically.
|
/pj-rehearse periodic-ci-openshift-cluster-version-operator-release-5.0-periodics-e2e-gcp-compact-install |
|
@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
miyadav
force-pushed
the
ocpcloud3368tests
branch
from
31f71da to
ca2505e
Compare
|
/pj-rehearse periodic-ci-openshift-cluster-version-operator-release-5.0-periodics-e2e-gcp-compact-install |
|
@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@miyadav: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
/hold
Summary by CodeRabbit
Added a new Cluster Version Operator
periodicsCI configuration for therelease-5.0branch inci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-5.0__periodics.yaml.This config builds the
cluster-version-operatorimage fromDockerfile.rhel, keeps5.0promotion disabled into theocpnamespace, and sets default pod resource requests (cpu: 100m,memory: 200Mi). It also introduces an E2E GCP compact-install periodic teste2e-gcp-compact-installrunning every168hwith thegcp-qeprofile, usingCUSTOM_OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDEto point to a release image override, and executes thecucushift-installer-rehearse-gcp-ipi-compactworkflow. Metadata is recorded foropenshift/cluster-version-operatorunder theperiodicsvariant andrelease-5.0branch.