Prow onboarding for osd-fleet-manager#81135
Conversation
Onboard openshift-online/osd-fleet-manager to OpenShift CI (Prow): - CI operator config with nested-podman for PostgreSQL-dependent tests - Prow plugin and Tide merge configuration - OWNERS files for config, jobs, and prow directories Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @Chee-Lu. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
Bot
added
the
needs-ok-to-test
WalkthroughAdds generated ownership files, Prow plugin and Tide configuration, and a new ci-operator job definition for openshift-online/osd-fleet-manager. Changesosd-fleet-manager onboarding
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Chee-Lu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
approved
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
ci-operator/config/openshift-online/osd-fleet-manager/openshift-online-osd-fleet-manager-main.yaml (2)
54-61: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueOptional: pin
gotestsumand avoid fixed sleep.Two small robustness nits in the unit/integration steps:
go install gotest.tools/gotestsum@latestis non-reproducible; pinning a version keeps CI deterministic.sleep 5aftermake db/setupis a fragile readiness assumption; a readiness poll (orpg_isreadyloop) is more reliable than a fixed wait.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-online/osd-fleet-manager/openshift-online-osd-fleet-manager-main.yaml` around lines 54 - 61, The CI setup step uses an unpinned gotestsum install and a fixed wait after database setup, both of which make the workflow fragile. Update the step that runs `go install gotest.tools/gotestsum@latest` to use a pinned version, and replace the `sleep 5` following `make db/setup` with a readiness check or poll that waits for the database to be available before running `make test`.
19-21: 🔒 Security & Privacy | 🔵 TrivialAdd SHA256 verification for the Go tarball.
go1.25.7.linux-amd64.tar.gzshould be checked before extraction; its SHA256 is12e6d6a191091ae27dc31f6efc630e3a3b8ba409baf3573d955b196fdf086005.♻️ Add checksum verification
- RUN curl -LO https://go.dev/dl/go1.25.7.linux-amd64.tar.gz && \ - tar -C /usr/local -xzf go1.25.7.linux-amd64.tar.gz && \ - rm go1.25.7.linux-amd64.tar.gz + RUN curl -LO https://go.dev/dl/go1.25.7.linux-amd64.tar.gz && \ + echo "12e6d6a191091ae27dc31f6efc630e3a3b8ba409baf3573d955b196fdf086005 go1.25.7.linux-amd64.tar.gz" | sha256sum -c - && \ + tar -C /usr/local -xzf go1.25.7.linux-amd64.tar.gz && \ + rm go1.25.7.linux-amd64.tar.gz🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-online/osd-fleet-manager/openshift-online-osd-fleet-manager-main.yaml` around lines 19 - 21, The Go toolchain download step in the Dockerfile snippet is missing checksum validation before extraction. Update the RUN sequence around the go1.25.7.linux-amd64.tar.gz download to verify the tarball’s SHA256 against 12e6d6a191091ae27dc31f6efc630e3a3b8ba409baf3573d955b196fdf086005 before calling tar, and keep the cleanup of the archive after verification.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift-online/osd-fleet-manager/openshift-online-osd-fleet-manager-main.yaml`:
- Around line 54-61: The CI setup step uses an unpinned gotestsum install and a
fixed wait after database setup, both of which make the workflow fragile. Update
the step that runs `go install gotest.tools/gotestsum@latest` to use a pinned
version, and replace the `sleep 5` following `make db/setup` with a readiness
check or poll that waits for the database to be available before running `make
test`.
- Around line 19-21: The Go toolchain download step in the Dockerfile snippet is
missing checksum validation before extraction. Update the RUN sequence around
the go1.25.7.linux-amd64.tar.gz download to verify the tarball’s SHA256 against
12e6d6a191091ae27dc31f6efc630e3a3b8ba409baf3573d955b196fdf086005 before calling
tar, and keep the cleanup of the archive after verification.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2a75d91f-c5fa-4b6b-9096-01d7e766d0c5
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift-online/osd-fleet-manager/OWNERSis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-online/osd-fleet-manager/openshift-online-osd-fleet-manager-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (5)
ci-operator/config/openshift-online/osd-fleet-manager/OWNERSci-operator/config/openshift-online/osd-fleet-manager/openshift-online-osd-fleet-manager-main.yamlcore-services/prow/02_config/openshift-online/osd-fleet-manager/OWNERScore-services/prow/02_config/openshift-online/osd-fleet-manager/_pluginconfig.yamlcore-services/prow/02_config/openshift-online/osd-fleet-manager/_prowconfig.yaml
|
/pj-rehearse |
|
@Chee-Lu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@Chee-Lu: needs-ok-to-test label found, no rehearsals will be run |
|
/verify-owners |
|
The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing
|
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
|
/retest |
|
/retest-required |
|
@Chee-Lu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
Onboard
openshift-online/osd-fleet-managerto OpenShift CI (Prow):ci-operator/config/openshift-online/osd-fleet-manager/): Defines builds and tests usingnested-podmanfor PostgreSQL-dependent unit and integration tests, with a customgolang-plusimagecore-services/prow/02_config/openshift-online/osd-fleet-manager/): Standard plugin set, external plugins, Tide merge rules with squash mergeTest plan
/pj-rehearseto run test rehearsals/pj-rehearse ackafter rehearsals pass