Skip to content

PTPCI: Slim down nightly runs#81139

Draft
nocturnalastro wants to merge 1 commit into
openshift:mainfrom
nocturnalastro:slim_down_ptp_nightlies
Draft

PTPCI: Slim down nightly runs#81139
nocturnalastro wants to merge 1 commit into
openshift:mainfrom
nocturnalastro:slim_down_ptp_nightlies

Conversation

@nocturnalastro

@nocturnalastro nocturnalastro commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR reduces and reshapes Telco 5G/PTP nightly CI coverage for the OpenShift release configuration by removing several e2e-telco5g-ptp jobs across older nightly streams and reworking the remaining schedules in newer ones.

Practically, this:

  • drops the PTP nightly job from multiple release branches where it is no longer needed,
  • removes the older e2e-telco5g-ptp-upstream variant in some streams,
  • adjusts cron timing and runtime settings for the remaining Telco 5G jobs,
  • and, in 4.18, replaces the old PTP job with newer network-flow-matrix job variants for Telco 5G coverage.

It also makes a small resource request adjustment to the e2e-aws-driver-toolkit job in one release config.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Nightly OpenShift release configs drop several e2e-telco5g-ptp jobs, add network-flow-matrix Telco 5G variants in 4.18, and retune telco cron/env settings in 4.22 and 5.0. Two e2e-aws-driver-toolkit resource request blocks are also updated.

Changes

AWS driver toolkit resource updates

Layer / File(s) Summary
Resource requests
ci-operator/config/openshift/release/openshift-release-main__nightly-4.13.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-4.17.yaml
e2e-aws-driver-toolkit keeps a CPU-only request in 4.13 and changes its resources.requests block again in 4.17.

Telco 5G periodic job changes

Layer / File(s) Summary
Remove ptp jobs
ci-operator/config/openshift/release/openshift-release-main__nightly-4.12.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-4.13.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-4.14.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-4.15.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-4.16.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-4.17.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yaml
e2e-telco5g-ptp entries are deleted from the 4.12, 4.13, 4.14, 4.15, 4.16, 4.17, 4.19, 4.20, 4.21, and 4.23 nightly configs.
Add network-flow-matrix jobs
ci-operator/config/openshift/release/openshift-release-main__nightly-4.18.yaml
4.18 replaces e2e-telco5g-ptp with Telco 5G network-flow-matrix variants and updated cron, T5CI_JOB_TYPE, workflow, and cluster_profile wiring.
Retune schedules
ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
4.22 updates the e2e-telco5g-ptp cron and removes e2e-telco5g-ptp-upstream; 5.0 updates both job crons and switches SKIP_OCP_INSTALL to false for upstream.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: reducing or trimming nightly test runs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only edits ci-operator YAML job definitions; no Go/Ginkgo test titles or dynamic test names were added or changed.
Test Structure And Quality ✅ Passed PR only changes ci-operator YAML configs; diff has 0 Go files and no Ginkgo test implementations to inspect.
Microshift Test Compatibility ✅ Passed PR only edits nightly CI YAML job schedules/resources; no Ginkgo test code was added or modified, so the MicroShift check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Config-only PR; no new Ginkgo test bodies. Added single-node variants use SNO-specific refs/workflows, so no new SNO-risky test found.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator release YAML test-job configs changed; no deployment manifests, operator code, or controllers were modified.
Ote Binary Stdout Contract ✅ Passed PR only edits ci-operator nightly YAMLs; no process-level OTE binary code or stdout writes were touched.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: This PR only edits ci-operator nightly YAMLs (job removals/cron tweaks); no Ginkgo test code or new It()/Describe() blocks were added, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto ✅ Passed Touched nightly YAMLs only; precise scans found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom-crypto patterns.
Container-Privileges ✅ Passed Touched YAMLs only remove jobs or tweak cron/resources; searches found no privileged:true, host* , SYS_ADMIN, or allowPrivilegeEscalation:true fields.
No-Sensitive-Data-In-Logs ✅ Passed PR only edits CI YAML job schedules/tests; diff search found no logging changes or sensitive strings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@nocturnalastro nocturnalastro force-pushed the slim_down_ptp_nightlies branch from a80888b to b2957ba Compare June 26, 2026 12:10
@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nocturnalastro
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@nocturnalastro: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-4.18-e2e-aws-driver-toolkit N/A periodic Ci-operator config changed

The following jobs are not rehearsable without the network-access-rehearsals-ok, and approved labels present on this PR. This is due to the restrict_network_access field being set to false. The network-access-rehearsals-ok label can be added by any openshift org member other than the PR's author by commenting: /pj-rehearse network-access-allowed:

Test name
periodic-ci-openshift-release-main-nightly-4.22-e2e-telco5g-ptp
periodic-ci-openshift-release-main-nightly-5.0-e2e-telco5g-ptp-upstream
periodic-ci-openshift-release-main-nightly-5.0-e2e-telco5g-ptp
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`:
- Around line 1812-1816: The job configuration is increasing CI load instead of
reducing it, so revert the schedule and install-path change in the affected
release job definition. Update the cron in the job stanza to keep the run
frequency slimmed down again, and restore the SKIP_OCP_INSTALL setting so the
job does not force the full install path; check the surrounding job block in
openshift-release-main__nightly-5.0.yaml to keep the intended lightweight
behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3420efb0-aaa4-4d61-b1c8-eca2f526f793

📥 Commits

Reviewing files that changed from the base of the PR and between fe1ccd3 and b2957ba.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (13)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.12.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.13.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.14.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.15.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.16.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.17.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.18.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
💤 Files with no reviewable changes (11)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.13.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.18.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.16.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.12.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.15.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.14.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.17.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml

Comment on lines +1812 to +1816
cron: 0 6 * * 0-5
restrict_network_access: false
steps:
env:
SKIP_OCP_INSTALL: "true"
SKIP_OCP_INSTALL: "false"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Performance & Scalability | 🟠 Major | ⚡ Quick win

This upstream job now expands nightly load instead of slimming it down.

Changing the cron from weekly to 0 6 * * 0-5 makes this run six times per week, and SKIP_OCP_INSTALL: "false" now exercises the full install path. That materially increases CI consumption and looks opposite to this PR’s stated goal.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`
around lines 1812 - 1816, The job configuration is increasing CI load instead of
reducing it, so revert the schedule and install-path change in the affected
release job definition. Update the cron in the job stanza to keep the run
frequency slimmed down again, and restore the SKIP_OCP_INSTALL setting so the
job does not force the full install path; check the surrounding job block in
openshift-release-main__nightly-5.0.yaml to keep the intended lightweight
behavior.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we removed many others.

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@nocturnalastro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generated-config b2957ba link true /test generated-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nocturnalastro nocturnalastro marked this pull request as draft June 26, 2026 14:30
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant