PTPCI: Slim down nightly runs#81139
Conversation
WalkthroughNightly OpenShift release configs drop several ChangesAWS driver toolkit resource updates
Telco 5G periodic job changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
a80888b to
b2957ba
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nocturnalastro The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
|
[REHEARSALNOTIFIER]
The following jobs are not rehearsable without the
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`:
- Around line 1812-1816: The job configuration is increasing CI load instead of
reducing it, so revert the schedule and install-path change in the affected
release job definition. Update the cron in the job stanza to keep the run
frequency slimmed down again, and restore the SKIP_OCP_INSTALL setting so the
job does not force the full install path; check the surrounding job block in
openshift-release-main__nightly-5.0.yaml to keep the intended lightweight
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3420efb0-aaa4-4d61-b1c8-eca2f526f793
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/release/openshift-release-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (13)
ci-operator/config/openshift/release/openshift-release-main__nightly-4.12.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.13.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.14.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.15.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.16.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.17.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.18.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yamlci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
💤 Files with no reviewable changes (11)
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yaml
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.13.yaml
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.18.yaml
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.16.yaml
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.12.yaml
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.15.yaml
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yaml
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.14.yaml
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.17.yaml
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml
| cron: 0 6 * * 0-5 | ||
| restrict_network_access: false | ||
| steps: | ||
| env: | ||
| SKIP_OCP_INSTALL: "true" | ||
| SKIP_OCP_INSTALL: "false" |
There was a problem hiding this comment.
🚀 Performance & Scalability | 🟠 Major | ⚡ Quick win
This upstream job now expands nightly load instead of slimming it down.
Changing the cron from weekly to 0 6 * * 0-5 makes this run six times per week, and SKIP_OCP_INSTALL: "false" now exercises the full install path. That materially increases CI consumption and looks opposite to this PR’s stated goal.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`
around lines 1812 - 1816, The job configuration is increasing CI load instead of
reducing it, so revert the schedule and install-path change in the affected
release job definition. Update the cron in the job stanza to keep the run
frequency slimmed down again, and restore the SKIP_OCP_INSTALL setting so the
job does not force the full install path; check the surrounding job block in
openshift-release-main__nightly-5.0.yaml to keep the intended lightweight
behavior.
There was a problem hiding this comment.
But we removed many others.
|
@nocturnalastro: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary by CodeRabbit
This PR reduces and reshapes Telco 5G/PTP nightly CI coverage for the OpenShift release configuration by removing several
e2e-telco5g-ptpjobs across older nightly streams and reworking the remaining schedules in newer ones.Practically, this:
e2e-telco5g-ptp-upstreamvariant in some streams,It also makes a small resource request adjustment to the
e2e-aws-driver-toolkitjob in one release config.