Add Slack notification for LVMS CI Doctor to #team-ocp-edge-notifications#81150
Add Slack notification for LVMS CI Doctor to #team-ocp-edge-notifications#81150kasturinarra wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe LVMS CI post step now mounts a Slack webhook credential and, for periodic jobs, posts a Slack notification containing the LVMS CI Doctor report artifact and Prow log links. Notification failures are non-fatal. ChangesLVMS CI Slack notification
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-lvms-ci-doctor |
|
@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/openshift/edge-tooling/lvms-ci/post/openshift-edge-tooling-lvms-ci-post-commands.sh`:
- Around line 41-45: The Slack notification call in the post script can hang
indefinitely because the curl invocation has no connect/read bounds; update the
webhook request in openshift-edge-tooling-lvms-ci-post-commands.sh to use
explicit timeout settings on the curl command so a slow or blackholed endpoint
fails quickly. Keep the existing best-effort behavior and message handling
around the webhook post, but make sure the timeout is applied directly in the
curl call that posts PAYLOAD to the URL read from WEBHOOK_FILE.
- Around line 36-43: The Slack notification block in
openshift-edge-tooling-lvms-ci-post-commands.sh leaks the webhook URL because
xtrace is still enabled when curl expands $(cat "${WEBHOOK_FILE}"). Update the
webhook posting section that builds REPORT_URL, MESSAGE, PAYLOAD, and calls curl
by disabling tracing with set +x before reading/posting the webhook, then
restoring it afterward (or keep xtrace off for the whole script) so the secret
never appears in job logs.
In
`@ci-operator/step-registry/openshift/edge-tooling/lvms-ci/post/openshift-edge-tooling-lvms-ci-post-ref.yaml`:
- Line 21: The step description is documenting the wrong Slack destination: the
YAML summary currently says the notification goes to team-ocp-edge, but the
corresponding posting logic uses the team-ocp-edge-notifications channel. Update
the text in the affected step metadata to match the actual channel used by the
companion script so the documented destination aligns with the implementation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 227110e5-3f2b-49eb-bdd8-a60e38f45cc9
📒 Files selected for processing (2)
ci-operator/step-registry/openshift/edge-tooling/lvms-ci/post/openshift-edge-tooling-lvms-ci-post-commands.shci-operator/step-registry/openshift/edge-tooling/lvms-ci/post/openshift-edge-tooling-lvms-ci-post-ref.yaml
kasturinarra
force-pushed
the
lvms-ci-doctor-slack-notify
branch
from
18f3c59 to
c2a8ab5
Compare
openshift-ci
Bot
added
the
needs-rebase
The LVMS CI Doctor report currently only notifies #lvms-release-coordination via Prow reporter_config. Since Prow only supports a single Slack channel, add a webhook-based notification in the post step to also send the report link to #team-ocp-edge-notifications. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci
Bot
removed
the
approved
- Disable xtrace around the curl that reads the webhook secret so the URL does not leak into CI logs - Add --connect-timeout 10 --max-time 30 to prevent indefinite hangs - Fix documentation to say team-ocp-edge-notifications (not team-ocp-edge) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kasturinarra
force-pushed
the
lvms-ci-doctor-slack-notify
branch
from
c2a8ab5 to
5b42d69
Compare
openshift-ci
Bot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-lvms-ci-doctor |
|
@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@kasturinarra: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary
#team-ocp-edge-notificationsreporter_configonly supports a single channel (#lvms-release-coordination), so a webhook curl in the post step covers the second channeledge-tooling-ci-monitor-slack-webhookVault secret (already contains theteam-ocp-edge-notificationswebhook)Changes
openshift-edge-tooling-lvms-ci-post-ref.yaml— added credential mount for the slack webhook secretopenshift-edge-tooling-lvms-ci-post-commands.sh— added curl to post report link via webhook after downloading the reportTest plan
pj-rehearse)#team-ocp-edge-notifications🤖 Generated with Claude Code
Summary by CodeRabbit
This PR updates the OpenShift CI “LVMS CI Doctor” post-step so that periodic LVMS CI Doctor runs also notify
#team-ocp-edge-notificationsin Slack. Practically, this ensures the report artifact link and corresponding Prow log links reach the edge notifications channel as well as the existing Prow-reporter channel, working around Prow’sreporter_configsingle-Slack-channel limitation.It does this by:
openshift-edge-tooling-lvms-ci-postjob spec to mount the existingedge-tooling-ci-monitor-slack-webhookVault secret (exposing it at/var/run/slack-webhook)openshift-edge-tooling-lvms-ci-post-commands.shtocurlthe Slack webhook and post the report + Prow log links after the report is detectedperiodicjobs only (not presubmits)