Skip to content

trusted-execution-clusters: Remove operator test#81152

Open
Jakob-Naucke wants to merge 1 commit into
openshift:mainfrom
Jakob-Naucke:no-tec-operator
Open

trusted-execution-clusters: Remove operator test#81152
Jakob-Naucke wants to merge 1 commit into
openshift:mainfrom
Jakob-Naucke:no-tec-operator

Conversation

@Jakob-Naucke

@Jakob-Naucke Jakob-Naucke commented Jun 26, 2026

Copy link
Copy Markdown
Member

Test relied on moving PR code to another host and running KinD there, which has been superseded by running on GHA
trusted-execution-clusters/operator#287.

Keeping basic structure for trusted-execution-clusters because we still intend to utilize OpenShift on #79393.

Summary by CodeRabbit

This PR removes the legacy trusted-execution-clusters operator CI test flow that depended on moving PR code to a Beaker host and running KinD there. The deleted step-registry entries, scripts, and generated metadata covered the full remote provisioning, test execution, cleanup, and artifact collection path.

In practical terms, the operator integration test is no longer driven through this CI-operator/Beaker workflow and is expected to run via GitHub Actions instead. The broader trusted-execution-clusters structure is left in place so it can still support future OpenShift-related CI use.

Test relied on moving PR code to another host and running KinD there,
which has been superseded by running on GHA
trusted-execution-clusters/operator#287.

Keeping basic structure for trusted-execution-clusters because we
still intend to utilize OpenShift on openshift#79393.

Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0ccb5bed-0ef3-4f3b-a9aa-027df8ea3eb7

📥 Commits

Reviewing files that changed from the base of the PR and between f410fa3 and e1ae924.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (32)
  • ci-operator/config/trusted-execution-clusters/OWNERS
  • ci-operator/config/trusted-execution-clusters/operator/OWNERS
  • ci-operator/config/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main.yaml
  • ci-operator/step-registry/trusted-execution-clusters/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/operator/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/operator/cleanup/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/operator/cleanup/trusted-execution-clusters-operator-cleanup-chain.metadata.json
  • ci-operator/step-registry/trusted-execution-clusters/operator/cleanup/trusted-execution-clusters-operator-cleanup-chain.yaml
  • ci-operator/step-registry/trusted-execution-clusters/operator/infra-provision/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/operator/infra-provision/trusted-execution-clusters-operator-infra-provision-chain.metadata.json
  • ci-operator/step-registry/trusted-execution-clusters/operator/infra-provision/trusted-execution-clusters-operator-infra-provision-chain.yaml
  • ci-operator/step-registry/trusted-execution-clusters/operator/lifecycle/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/operator/lifecycle/trusted-execution-clusters-operator-lifecycle-chain.metadata.json
  • ci-operator/step-registry/trusted-execution-clusters/operator/lifecycle/trusted-execution-clusters-operator-lifecycle-chain.yaml
  • ci-operator/step-registry/trusted-execution-clusters/ref/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-deprovision/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-deprovision/trusted-execution-clusters-ref-operator-beaker-deprovision-commands.sh
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-deprovision/trusted-execution-clusters-ref-operator-beaker-deprovision-ref.metadata.json
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-deprovision/trusted-execution-clusters-ref-operator-beaker-deprovision-ref.yaml
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-kind-provision/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-kind-provision/trusted-execution-clusters-ref-operator-beaker-kind-provision-commands.sh
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-kind-provision/trusted-execution-clusters-ref-operator-beaker-kind-provision-ref.metadata.json
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-kind-provision/trusted-execution-clusters-ref-operator-beaker-kind-provision-ref.yaml
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/kind-cluster-create/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/kind-cluster-create/trusted-execution-clusters-ref-operator-kind-cluster-create-commands.sh
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/kind-cluster-create/trusted-execution-clusters-ref-operator-kind-cluster-create-ref.metadata.json
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/kind-cluster-create/trusted-execution-clusters-ref-operator-kind-cluster-create-ref.yaml
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/test/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/test/trusted-execution-clusters-ref-operator-test-commands.sh
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/test/trusted-execution-clusters-ref-operator-test-ref.metadata.json
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/test/trusted-execution-clusters-ref-operator-test-ref.yaml
💤 Files with no reviewable changes (32)
  • ci-operator/config/trusted-execution-clusters/operator/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/operator/infra-provision/trusted-execution-clusters-operator-infra-provision-chain.metadata.json
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/kind-cluster-create/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/operator/lifecycle/trusted-execution-clusters-operator-lifecycle-chain.metadata.json
  • ci-operator/step-registry/trusted-execution-clusters/operator/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/operator/infra-provision/trusted-execution-clusters-operator-infra-provision-chain.yaml
  • ci-operator/step-registry/trusted-execution-clusters/operator/cleanup/trusted-execution-clusters-operator-cleanup-chain.metadata.json
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/test/trusted-execution-clusters-ref-operator-test-ref.yaml
  • ci-operator/step-registry/trusted-execution-clusters/operator/lifecycle/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/test/trusted-execution-clusters-ref-operator-test-commands.sh
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-kind-provision/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-kind-provision/trusted-execution-clusters-ref-operator-beaker-kind-provision-ref.yaml
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/kind-cluster-create/trusted-execution-clusters-ref-operator-kind-cluster-create-commands.sh
  • ci-operator/config/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main.yaml
  • ci-operator/step-registry/trusted-execution-clusters/operator/cleanup/trusted-execution-clusters-operator-cleanup-chain.yaml
  • ci-operator/step-registry/trusted-execution-clusters/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/operator/cleanup/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/test/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/operator/infra-provision/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/kind-cluster-create/trusted-execution-clusters-ref-operator-kind-cluster-create-ref.metadata.json
  • ci-operator/config/trusted-execution-clusters/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-deprovision/trusted-execution-clusters-ref-operator-beaker-deprovision-ref.yaml
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-kind-provision/trusted-execution-clusters-ref-operator-beaker-kind-provision-commands.sh
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-deprovision/trusted-execution-clusters-ref-operator-beaker-deprovision-commands.sh
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-deprovision/trusted-execution-clusters-ref-operator-beaker-deprovision-ref.metadata.json
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-deprovision/OWNERS
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/beaker-kind-provision/trusted-execution-clusters-ref-operator-beaker-kind-provision-ref.metadata.json
  • ci-operator/step-registry/trusted-execution-clusters/operator/lifecycle/trusted-execution-clusters-operator-lifecycle-chain.yaml
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/kind-cluster-create/trusted-execution-clusters-ref-operator-kind-cluster-create-ref.yaml
  • ci-operator/step-registry/trusted-execution-clusters/ref/operator/test/trusted-execution-clusters-ref-operator-test-ref.metadata.json

Walkthrough

Updates trusted-execution-clusters OWNERS files across config and step-registry paths, removing yalzhang and fangge1212 from reviewer/approver lists and leaving the remaining ownership entries as shown in each file.

Changes

Trusted Execution Clusters OWNERS updates

Layer / File(s) Summary
OWNERS list updates
ci-operator/config/trusted-execution-clusters/OWNERS, ci-operator/config/trusted-execution-clusters/operator/OWNERS, ci-operator/step-registry/trusted-execution-clusters/OWNERS, ci-operator/step-registry/trusted-execution-clusters/ref/OWNERS
Reviewer and approver entries were updated across the trusted-execution-clusters OWNERS files, removing yalzhang and fangge1212 and updating the remaining names per file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: removing the trusted-execution-clusters operator test workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Relevant changed files are OWNERS/YAML/sh/json only; no Go tests or Ginkgo titles were added, and no It/Describe/Context/When matches were found.
Test Structure And Quality ✅ Passed No Ginkgo test code is changed here; the PR only removes CI config/OWNERS/scripts/YAML, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed No Go/Ginkgo e2e tests were added or changed; the PR only removes CI/operator test assets and ownership files.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR only removes OWNERS/YAML/script entries under trusted-execution-clusters; no new Go/Ginkgo e2e tests or multi-node assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed The PR only removes CI step/manifests and updates OWNERS; it adds no pod scheduling constraints, node selectors, anti-affinity, or topology spread logic.
Ote Binary Stdout Contract ✅ Passed PR only adds/removes OWNERS/YAML and deletes shell steps; no added main/TestMain/init code or stdout writes in process-level code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only removes trusted-execution-clusters test YAML/scripts and leaves only OWNERS files in that subtree; no new Ginkgo e2e tests or network assumptions were added.
No-Weak-Crypto ✅ Passed Touched code files had no weak-crypto algorithms or secret/token compares; the PR is mostly deletions of operator test assets.
Container-Privileges ✅ Passed No touched manifest contains privileged/root/hostNetwork/hostPID/hostIPC/SYS_ADMIN/allowPrivilegeEscalation settings; the PR mainly deletes those files.
No-Sensitive-Data-In-Logs ✅ Passed PASS: the PR removes test/step-registry files; the remaining trusted-execution-clusters files are OWNERS only, and no log/sensitive patterns were found.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from alicefr and psalajova June 26, 2026 14:48
@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jakob-Naucke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 26, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Jakob-Naucke: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2026
@Jakob-Naucke

Copy link
Copy Markdown
Member Author

required diff by ci/prow/generated-config is also on main, let's wait a bit and rebase

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@Jakob-Naucke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generated-config e1ae924 link true /test generated-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant