HYPERFLEET-1296: add --flake-attempts to openshift-hyperfleet-e2e-test step

[kuudori]

What

Add --flake-attempts="${FLAKE_ATTEMPTS:-2}" to the openshift-hyperfleet-e2e-test step invocation.

Why

The step invokes the binary directly (not via make e2e-ci), so --flake-attempts was never passed. The binary defaults to 1 (no retries). make e2e-ci passes --flake-attempts=2 — this aligns CI with that behavior.

Default is 2 via ${FLAKE_ATTEMPTS:-2}, overridable via env var.

Fixes: https://issues.redhat.com/browse/HYPERFLEET-1296

Summary by CodeRabbit

This PR updates the OpenShift CI step for Hyperfleet E2E tests to retry flaky runs by passing --flake-attempts="${FLAKE_ATTEMPTS:-2}" to the hyperfleet-e2e test invocation. This aligns the openshift-hyperfleet-e2e-test step’s behavior with make e2e-ci, while keeping the default overridable via the FLAKE_ATTEMPTS environment variable.

[openshift-ci-robot]

@kuudori: This pull request references HYPERFLEET-1296 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What

Add --flake-attempts="${FLAKE_ATTEMPTS:-2}" to the openshift-hyperfleet-e2e-test step invocation.

Why

The step invokes the binary directly (not via make e2e-ci), so --flake-attempts was never passed. The binary defaults to 1 (no retries). make e2e-ci passes --flake-attempts=2 — this aligns CI with that behavior.

Default is 2 via ${FLAKE_ATTEMPTS:-2}, overridable via env var.

Fixes: https://issues.redhat.com/browse/HYPERFLEET-1296

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 42b4e3c1-5946-43ee-b4c4-dbd7d43041cc

📥 Commits

Reviewing files that changed from the base of the PR and between 233869a and 5d2716c.

📒 Files selected for processing (1)

• ci-operator/step-registry/openshift-hyperfleet/e2e/test/openshift-hyperfleet-e2e-test-commands.sh

---

Walkthrough

The E2E test script adds a configurable --flake-attempts argument to the hyperfleet-e2e test command, defaulting to 2 when FLAKE_ATTEMPTS is unset.

Changes

OpenShift Hyperfleet E2E script

Layer / File(s)	Summary
E2E command retry flag ci-operator/step-registry/openshift-hyperfleet/e2e/test/openshift-hyperfleet-e2e-test-commands.sh	hyperfleet-e2e test appends --flake-attempts="${FLAKE_ATTEMPTS:-2}" to the existing command line.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately describes the main change: adding --flake-attempts to the openshift-hyperfleet-e2e-test step.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only edits a shell script to add --flake-attempts; no Ginkgo test titles (It/Describe/Context/When) are added or modified.
Test Structure And Quality	✅ Passed	Only a ci-operator step shell script changed; no Ginkgo test code, setup/cleanup, or Eventually/It blocks to evaluate.
Microshift Test Compatibility	✅ Passed	The PR only updates a shell command flag in the e2e step; it adds no Ginkgo tests or API/resource references, so MicroShift compatibility is unaffected.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR only changes a CI shell invocation to add flake-attempts; no new Ginkgo tests or SNO-sensitive topology assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The PR only changes an e2e test shell invocation to add flake attempts; it does not add manifests, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	Only a ci-operator shell wrapper changed; it adds --flake-attempts and does not touch any OTE binary/main-process stdout code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only adds --flake-attempts to an existing shell invocation; no new Ginkgo tests, IP literals, or external connectivity requirements were introduced.
No-Weak-Crypto	✅ Passed	Only change is adding --flake-attempts to a shell test invocation; no weak crypto, custom crypto, or secret comparisons appear in the diff.
Container-Privileges	✅ Passed	The PR only adds a flake-attempts flag in a shell step script; no privileged/container securityContext settings are introduced.
No-Sensitive-Data-In-Logs	✅ Passed	The only change adds a test flag to the command; it does not introduce logging of passwords, tokens, PII, or other sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@kuudori: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-deployment-validation	openshift-hyperfleet/hyperfleet-e2e	presubmit	Registry content changed
periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier2-nightly	N/A	periodic	Registry content changed
periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-rc-e2e-rc-e2e	N/A	periodic	Registry content changed
periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier0-nightly	N/A	periodic	Registry content changed
periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier1-nightly	N/A	periodic	Registry content changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[rh-amarin]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuudori, rh-amarin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/openshift-hyperfleet/OWNERS [kuudori,rh-amarin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kuudori]

/pj-rehearse auto-ack

[openshift-merge-bot]

@kuudori: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@kuudori: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier1-nightly	5d2716c	link	unknown	/pj-rehearse periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier1-nightly
ci/rehearse/periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier2-nightly	5d2716c	link	unknown	/pj-rehearse periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier2-nightly
ci/rehearse/periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-rc-e2e-rc-e2e	5d2716c	link	unknown	/pj-rehearse periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-rc-e2e-rc-e2e
ci/rehearse/openshift-hyperfleet/hyperfleet-e2e/main/e2e-deployment-validation	5d2716c	link	unknown	/pj-rehearse pull-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-deployment-validation

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.