Skip to content

[o/external-secrets-operator] ESO-424: Use Makefile default for e2e label filter in CI#81155

Open
bharath-b-rh wants to merge 1 commit into
openshift:mainfrom
bharath-b-rh:eso-424
Open

[o/external-secrets-operator] ESO-424: Use Makefile default for e2e label filter in CI#81155
bharath-b-rh wants to merge 1 commit into
openshift:mainfrom
bharath-b-rh:eso-424

Conversation

@bharath-b-rh

@bharath-b-rh bharath-b-rh commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

The PR is to use the e2e label filter defined in Makefile of external-secrets-operator instead of redefining it here.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@bharath-b-rh: This pull request references ESO-424 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

The PR is for updating the e2e label filter of external-secrets-operator to be more fine grained and include more testcases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2026
@openshift-ci openshift-ci Bot requested review from mytreya-rh and swghosh June 26, 2026 15:37
Signed-off-by: Bharath B <bhb@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The CI configs for external-secrets-operator now run make test-e2e without setting E2E_GINKGO_LABEL_FILTER in the main and release-1.2 e2e command steps.

Changes

External Secrets Operator CI e2e command updates

Layer / File(s) Summary
Remove label filter from e2e commands
ci-operator/config/openshift/external-secrets-operator/openshift-external-secrets-operator-main.yaml, ci-operator/config/openshift/external-secrets-operator/openshift-external-secrets-operator-release-1.2.yaml
e2e-operator and publish-e2e-coverage in the main config, plus e2e-operator in release-1.2, now invoke make test-e2e directly without E2E_GINKGO_LABEL_FILTER.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openshift/release#80905: Also changes external-secrets-operator OpenShift CI e2e command filtering in the same config family.

Suggested labels

lgtm, approved

Suggested reviewers

  • swghosh
  • mytreya-rh
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: CI now uses the Makefile default e2e label filter.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only changes ci-operator YAML commands; no Go Ginkgo specs or test titles were added or modified, so there are no unstable test names to flag.
Test Structure And Quality ✅ Passed PR only changes ci-operator YAML; no Ginkgo test code was modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed No Ginkgo test code was added or changed; this PR only alters CI commands/label filtering, so MicroShift compatibility review is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator YAMLs changed; no Go/e2e test files or Ginkgo specs were added, so there are no new SNO-sensitive assumptions to flag.
Topology-Aware Scheduling Compatibility ✅ Passed PR only changes ci-operator e2e commands; no manifests/controllers or scheduling fields (node selectors, affinities, spread, replicas) were introduced.
Ote Binary Stdout Contract ✅ Passed The PR only changes ci-operator YAML test commands; no process-level Go/Ginkgo code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e test code was added; the PR only changes ci-operator YAML commands, so this compatibility check is not applicable.
No-Weak-Crypto ✅ Passed PASS: The only changes are CI YAML commands switching to make test-e2e; no weak-crypto algorithms, custom crypto, or secret comparisons appear in the patch.
Container-Privileges ✅ Passed Changed ci-operator configs only tweak make test-e2e commands; no privileged, hostNetwork, hostPID/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings were added.
No-Sensitive-Data-In-Logs ✅ Passed Changed CI commands only; no new logging of passwords, tokens, PII, or hostnames was added, and the e2e filter removal reduces output risk.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bharath-b-rh bharath-b-rh changed the title [o/external-secrets-operator] ESO-424: Updates the e2e label filter to include more testcases [o/external-secrets-operator] ESO-424: Use Makefile default for e2e label filter in CI Jun 26, 2026
@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bharath-b-rh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-external-secrets-operator-main-e2e-operator openshift/external-secrets-operator presubmit Ci-operator config changed
pull-ci-openshift-external-secrets-operator-release-1.2-e2e-operator openshift/external-secrets-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bharath-b-rh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-external-secrets-operator-main-e2e-operator openshift/external-secrets-operator presubmit Ci-operator config changed
pull-ci-openshift-external-secrets-operator-release-1.2-e2e-operator openshift/external-secrets-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bharath-b-rh

Copy link
Copy Markdown
Contributor Author

Failures in generated-config are in some other component and is not related to the changes in this PR. Hence overriding it.
/override ci/prow/generated-config

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@bharath-b-rh: bharath-b-rh unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

Failures in generated-config are in some other component and is not related to the changes in this PR. Hence overriding it.
/override ci/prow/generated-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@bharath-b-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generated-config db80a7c link true /test generated-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants