Skip to content

openshift-logging: Update Go builders for Loki Operator to 1.26#81159

Open
xperimental wants to merge 1 commit into
openshift:mainfrom
xperimental:update-go-builder-loki-operator
Open

openshift-logging: Update Go builders for Loki Operator to 1.26#81159
xperimental wants to merge 1 commit into
openshift:mainfrom
xperimental:update-go-builder-loki-operator

Conversation

@xperimental

@xperimental xperimental commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

/cc @btaani @JoaoBraveCoding
/assign @xperimental

Summary by CodeRabbit

This PR updates the OpenShift Logging (openshift-logging) CI configuration for the Loki Operator to use Go 1.26 for its build environment.

Concretely:

  • In ci-operator/config/openshift/loki/openshift-loki-release-6.0.yaml, openshift-loki-release-6.2.yaml, and openshift-loki-release-6.5.yaml, the CI build_root.image_stream_tag.tag is bumped from the Go 1.24/1.25-based builder images to the Go 1.26-based builder image tag.
  • In ci-operator/config/openshift/loki/openshift-loki-release-6.4.yaml, the prior go_builder base image wiring is removed and the loki-operator source stage is changed to use a dockerfile_literal stage that pulls registry.redhat.io/ubi9/go-toolset:latest, with base passed as the go-toolset input.

Overall, affected Loki Operator release jobs are moved onto the Go 1.26 toolchain in their CI build setups.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0323ca83-eb26-4b5d-be1c-3442adb6a1b5

📥 Commits

Reviewing files that changed from the base of the PR and between cdee3b5 and d93be18.

📒 Files selected for processing (4)
  • ci-operator/config/openshift/loki/openshift-loki-release-6.0.yaml
  • ci-operator/config/openshift/loki/openshift-loki-release-6.2.yaml
  • ci-operator/config/openshift/loki/openshift-loki-release-6.4.yaml
  • ci-operator/config/openshift/loki/openshift-loki-release-6.5.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/openshift/loki/openshift-loki-release-6.4.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
  • ci-operator/config/openshift/loki/openshift-loki-release-6.0.yaml
  • ci-operator/config/openshift/loki/openshift-loki-release-6.2.yaml
  • ci-operator/config/openshift/loki/openshift-loki-release-6.5.yaml

Walkthrough

The Loki release CI configs update Go builder image tags in 6.0, 6.2, and 6.5, and reconfigure the 6.4 operator source build to use ubi9/go-toolset with the base image input.

Changes

OpenShift Loki CI builder updates

Layer / File(s) Summary
Build root Go 1.26 tags
ci-operator/config/openshift/loki/openshift-loki-release-6.0.yaml, ci-operator/config/openshift/loki/openshift-loki-release-6.2.yaml, ci-operator/config/openshift/loki/openshift-loki-release-6.5.yaml
The 6.0, 6.2, and 6.5 release configs update build_root.image_stream_tag to rhel-9-golang-1.26-openshift-4.23.
6.4 operator source build
ci-operator/config/openshift/loki/openshift-loki-release-6.4.yaml
The 6.4 config removes go_builder from base_images and changes loki-operator-src to use registry.redhat.io/ubi9/go-toolset:latest with base wired in.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openshift/release#81093: Updates the same openshift-loki-release-6.4.yaml build configuration and Go builder/toolchain inputs.
  • openshift/release#80514: Also updates build_root.image_stream_tag values to newer Go-based builder images in release YAML.
  • openshift/release#80472: Another CI config update that bumps the build root Go image tag in a release YAML.

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • btaani
  • JoaoBraveCoding
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: updating Loki Operator Go builders to Go 1.26.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only CI YAML config files changed, and no Ginkgo-style test title strings appear in the referenced paths.
Test Structure And Quality ✅ Passed PASS: The PR only changes ci-operator YAML builder configs; no *_test.go files or Ginkgo blocks are touched, so the test-code quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only ci-operator YAML builder-image updates were changed; no new Ginkgo/e2e tests or MicroShift-unsafe test code was added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator YAML builder-image updates changed; no new or modified Ginkgo e2e tests were added, so SNO compatibility isn’t implicated.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator build-root/image config changed; no deployment manifests, replicas, affinity, node selectors, or controllers were modified.
Ote Binary Stdout Contract ✅ Passed PR only updates ci-operator YAML builder images and build inputs; no main/init/TestMain/suite setup code or stdout writes changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only updates CI YAML builder-image tags and a go-toolset input; no new Ginkgo e2e tests or IPv4/external-connectivity code were added.
No-Weak-Crypto ✅ Passed The changed CI YAMLs only update builder images and source stages; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear.
Container-Privileges ✅ Passed The changed Loki CI YAMLs only update builder images / Dockerfile literals; no privileged, hostPID/network/IPC, SYS_ADMIN, or root escalation settings are present.
No-Sensitive-Data-In-Logs ✅ Passed The PR only changes CI YAML builder image tags/inputs; no log statements, secrets, tokens, PII, or hostnames were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@xperimental xperimental force-pushed the update-go-builder-loki-operator branch from cdee3b5 to d93be18 Compare June 26, 2026 16:40
@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@xperimental: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-loki-release-6.2-build openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.2-ci-index-loki-operator-bundle openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.2-images openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.2-lint openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.2-test openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.2-test-operator openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.5-build openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.5-ci-index-loki-operator-bundle openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.5-images openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.5-lint openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.5-test openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.5-test-operator openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.4-build openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.4-ci-index-loki-operator-bundle openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.4-images openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.4-lint openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.4-test openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.4-test-operator openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.0-build openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.0-ci-index-loki-operator-bundle openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.0-images openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.0-lint openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.0-test openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-release-6.0-test-operator openshift/loki presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@xperimental: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generated-config d93be18 link true /test generated-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant