Skip to content

Added Prow CI oadp-1.4#81162

Open
NicholasYancey wants to merge 1 commit into
openshift:mainfrom
NicholasYancey:oadp-1.4-cli-prow
Open

Added Prow CI oadp-1.4#81162
NicholasYancey wants to merge 1 commit into
openshift:mainfrom
NicholasYancey:oadp-1.4-cli-prow

Conversation

@NicholasYancey

@NicholasYancey NicholasYancey commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Why the changes were made

migtools/oadp-cli has an oadp-1.4 release branch, but openshift/release has no Prow CI for it yet (only oadp-dev, oadp-1.5, oadp-1.6). PRs targeting oadp-1.4 therefore have no presubmit image build and no mirroring for that branch.

Summary by CodeRabbit

This PR extends OpenShift CI infrastructure for migtools/oadp-cli by adding Prow/migtools and mirroring support for the oadp-1.4 release branch. Practically, PRs targeting oadp-1.4 will now have their presubmit build and image promotion/mirroring handled the same way as the already-supported oadp-dev, oadp-1.5, and oadp-1.6 branches.

Concretely, it:

  • Adds a new migtools ci-operator configuration for oadp-cli-oadp-1.4, including the builder image stream tag (Konveyor namespace) and an OADP CLI image artifact mapping (with arm64 additional architecture) plus promotion rules into the oadp-cli image namespace.
  • Updates the image-mirroring mapping so the generated ci:konveyor_oadp-cli_oadp-cli-oadp-1.4 image is mirrored to the corresponding quay.io/konveyor/oadp-cli-binaries:oadp-1.4-latest tag.
  • Updates the Prow/Tide config to include oadp-1.4 in the set of branches considered for automated CI triggering.

Prow comments also indicate approval to proceed with testing via /ok-to-test and auto-acknowledgement for the rehearsal process.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3a5fd217-c96a-47c6-8432-4cc0a75edc0d

📥 Commits

Reviewing files that changed from the base of the PR and between f97eb79 and 31eaa39.

📒 Files selected for processing (1)
  • ci-operator/config/migtools/oadp-cli/migtools-oadp-cli-oadp-1.4.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/migtools/oadp-cli/migtools-oadp-cli-oadp-1.4.yaml

Walkthrough

This PR adds OADP CLI 1.4 CI operator config, image mirroring, and Tide branch inclusion.

Changes

OADP CLI 1.4 release wiring

Layer / File(s) Summary
Build and promotion config
ci-operator/config/migtools/oadp-cli/migtools-oadp-cli-oadp-1.4.yaml
Defines the OADP CLI 1.4 build root image, artifact mapping, promotion target, resource requests and limits, and generated metadata.
Mirror and Tide updates
core-services/image-mirroring/konveyor/mapping_konveyor_latest, core-services/prow/02_config/migtools/oadp-cli/_prowconfig.yaml
Adds the OADP CLI 1.4 source image mapping and includes oadp-1.4 in the Tide branch list.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: adding Prow CI support for the oadp-1.4 branch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only changes YAML config files and adds no Ginkgo test titles, so there are no dynamic test names to review.
Test Structure And Quality ✅ Passed No changed test file uses Ginkgo; the modified tests are standard testing-style unit tests, so the Ginkgo-specific quality check is not applicable.
Microshift Test Compatibility ✅ Passed PASS: The PR only changes CI/mirroring/prow YAML configs; no new Ginkgo e2e tests or test code were added, so MicroShift compatibility isn’t implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only changes YAML/configuration for CI, mirroring, and Tide branch inclusion; no new Ginkgo e2e tests or HA/multi-node assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI/Promote/Prow YAML changed; no deployment, operator, controller, pod affinity, nodeSelector, PDB, or replica settings were added.
Ote Binary Stdout Contract ✅ Passed Only YAML/PROW/mapping configs changed; no Go/test entrypoints or stdout writes were added, so the stdout contract isn’t impacted.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only changes CI/mirroring/prow config; no Ginkgo e2e tests or network-sensitive code was added.
No-Weak-Crypto ✅ Passed PR only adds CI/mirroring config; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear.
Container-Privileges ✅ Passed The added YAMLs only define ci-operator build/promotion, image mirroring, and Tide branch config; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields appear.
No-Sensitive-Data-In-Logs ✅ Passed The PR only changes YAML config entries; no log statements, secrets, tokens, or PII were added in the touched files.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NicholasYancey
Once this PR has been reviewed and has the lgtm label, please assign weshayutin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@NicholasYancey NicholasYancey force-pushed the oadp-1.4-cli-prow branch 2 times, most recently from db985d4 to f97eb79 Compare June 26, 2026 17:09
@NicholasYancey

Copy link
Copy Markdown
Contributor Author

/ok-to-test

@openshift-ci openshift-ci Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 26, 2026
@NicholasYancey

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@NicholasYancey: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 26, 2026
@NicholasYancey

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@NicholasYancey: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 26, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@NicholasYancey: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-migtools-oadp-cli-oadp-1.4-images migtools/oadp-cli presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@NicholasYancey: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant