Skip to content

WIP [INTEROP-9134] Add spoke cluster pre/post-upgrade OCP health check steps for ACM Virt Scenario #81164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sg-rh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP [INTEROP-9134] Add spoke cluster pre/post-upgrade OCP health check steps for ACM Virt Scenario #81164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ci-operator/step-registry/acm/interop-p2p/spoke-upgrade-healthcheck/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
approvers: &owners
- cspi-qe-ocp-lp
reviewers: *owners
57 changes: 57 additions & 0 deletions ci-operator/step-registry/acm/interop-p2p/spoke-upgrade-healthcheck/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
# acm-interop-p2p-spoke-upgrade-healthcheck

Post-upgrade health check for the **ACM managed spoke** after `acm-interop-p2p-spoke-upgrade`.

## Files

| File | Purpose |
|------|---------|
| `acm-interop-p2p-spoke-upgrade-healthcheck-ref.yaml` | Step registry ref (verification-tests image, same as cucushift) |
| `acm-interop-p2p-spoke-upgrade-healthcheck-commands.sh` | Sets spoke `KUBECONFIG`, then runs cucushift upgrade healthcheck logic |

The commands script embeds the body of
[`cucushift-upgrade-healthcheck-commands.sh`](../../../cucushift/upgrade/healthcheck/cucushift-upgrade-healthcheck-commands.sh)
without modifying the upstream file. When updating health check behavior, change cucushift first, then
refresh the embedded section in `acm-interop-p2p-spoke-upgrade-healthcheck-commands.sh`.

## Checks

1. MachineConfigPools — not Updating/Degraded, stable for 5 minutes (wait budget `max(ACM_SPOKE_MCP_READY_TIMEOUT_MINUTES, nodes × ACM_SPOKE_MCP_MINUTES_PER_NODE)`; defaults 210m / 35m per node)
2. Cluster operators — Available, not Progressing, not Degraded (`ACM_SPOKE_CO_READY_TIMEOUT_MINUTES`, default 45m)
3. Nodes — all Ready
4. Pods — status dump for reference

## Step timeout

| Setting | Default | Purpose |
|---------|---------|---------|
| `timeout` (ref.yaml) | 5h | MCP + CO budgets + margin (fits within 20h job) |
| `ACM_SPOKE_MCP_READY_TIMEOUT_MINUTES` | 210 | MCP wait floor |
| `ACM_SPOKE_MCP_MINUTES_PER_NODE` | 35 | MCP wait per node |
| `ACM_SPOKE_CO_READY_TIMEOUT_MINUTES` | 45 | CO stability poll budget |
| `grace_period` | 10m | EXIT trap diagnostics after step failure |

## Requirements

| File | Source |
|------|--------|
| `${SHARED_DIR}/kubeconfig` | Hub cluster (ipi-install) |
| Spoke admin kubeconfig | `${SHARED_DIR}/managed-cluster-kubeconfig` when names match, or Hive `ClusterDeployment` secret per spoke |

Optional env `ACM_INTEROP_P2P__HEALTHCHECK__SPOKE_CLUSTERS` limits which spokes are checked.
When unset, all `ManagedCluster` resources except `local-cluster` are checked.

## Artifacts on failure

| File | Content |
|------|---------|
| `spoke-<name>-upgrade-healthcheck-failure.txt` | ClusterVersion, MCP describe, not-Ready node describe, unhealthy CO describe, MCO pods |

## Typical workflow placement

```yaml
test:
- ref: acm-interop-p2p-spoke-upgrade
- ref: acm-interop-p2p-spoke-upgrade-healthcheck
- ref: interop-tests-openshift-virtualization-upgrade-tests
```
Loading