NO-ISSUE: Always run ISO_NO_REGISTRY job on assisted UI

[pawanpinjarkar]

Summary by CodeRabbit

Updated the Assisted Installer UI CI configuration so the ISO_NO_REGISTRY-related job runs unconditionally across the affected OpenShift release branches and master configs. In practical terms, this ensures the assisted UI’s lint/e2e coverage is always executed in CI instead of being skipped based on prior gating conditions.

[openshift-ci-robot]

@pawanpinjarkar: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 67f370b4-ef7d-484c-835a-e6b2e07b0590

📥 Commits

Reviewing files that changed from the base of the PR and between bc368da and f5c80a5.

⛔ Files ignored due to path filters (7)

• ci-operator/jobs/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-master-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.20-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.21-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.22-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.23-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-5.0-presubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-5.1-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (7)

• ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-master.yaml
• ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.20.yaml
• ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.21.yaml
• ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.22.yaml
• ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.23.yaml
• ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-5.0.yaml
• ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-5.1.yaml

---

Walkthrough

Seven Assisted Installer UI CI operator configs change one test-step always_run setting from false to true across master and release branches.

Changes

Assisted Installer UI CI configs

Layer / File(s)

Summary

Enable always_run ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-master.yaml, ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.20.yaml, ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.21.yaml, ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.22.yaml, ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-4.23.yaml, ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-5.0.yaml, ci-operator/config/openshift-assisted/assisted-installer-ui/openshift-assisted-assisted-installer-ui-release-5.1.yaml

Each config changes one test step’s always_run value from false to true.

Sequence Diagram(s)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: making the ISO_NO_REGISTRY assisted UI job always run.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The PR only flips always_run in ci-operator YAML/job configs; no Ginkgo It/Describe test titles were changed.
Test Structure And Quality	✅ Passed	Only ci-operator YAML changed; no Ginkgo test files or assertions were touched, so this test-structure check is not applicable.
Microshift Test Compatibility	✅ Passed	The PR only toggles always_run in ci-operator YAMLs; no Ginkgo tests or test code changed, so this MicroShift check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only ci-operator YAML changed; no Ginkgo e2e test code was added or modified, so this PR introduces no new SNO compatibility risk.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The PR only flips ci-operator test always_run flags; no topology-sensitive scheduling fields, replicas, node selectors, or affinity rules were added.
Ote Binary Stdout Contract	✅ Passed	Only CI operator YAML changed; no process-level code or stdout writes were modified, so the OTE stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only ci-operator YAML changed to flip always_run; no new Ginkgo tests or networking code were added, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto	✅ Passed	Touched files are ci-operator YAMLs only; diff only flips always_run on an e2e job. No weak-crypto terms, custom crypto, or secret comparisons found.
Container-Privileges	✅ Passed	Only always_run/trigger fields changed in CI config/job YAMLs; no privileged, hostPID/Network/IPC, SYS_ADMIN, or root settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	Touched files only flip CI always_run flags; scans found no log, secret, token, password, or PII strings in those configs.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[pawanpinjarkar]

/cc @andfasano @bfournie @sadasu

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pawanpinjarkar
Once this PR has been reviewed and has the lgtm label, please assign rawagner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift-assisted/assisted-installer-ui/OWNERS
• ci-operator/jobs/openshift-assisted/assisted-installer-ui/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@pawanpinjarkar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-assisted-assisted-installer-ui-master-e2e-agent-compact-ipv4-iso-no-registry	openshift-assisted/assisted-installer-ui	presubmit	Presubmit changed
pull-ci-openshift-assisted-assisted-installer-ui-release-4.20-e2e-agent-compact-ipv4-iso-no-registry	openshift-assisted/assisted-installer-ui	presubmit	Presubmit changed
pull-ci-openshift-assisted-assisted-installer-ui-release-4.21-e2e-agent-compact-ipv4-iso-no-registry	openshift-assisted/assisted-installer-ui	presubmit	Presubmit changed
pull-ci-openshift-assisted-assisted-installer-ui-release-4.22-e2e-agent-compact-ipv4-iso-no-registry	openshift-assisted/assisted-installer-ui	presubmit	Presubmit changed
pull-ci-openshift-assisted-assisted-installer-ui-release-4.23-e2e-agent-compact-ipv4-iso-no-registry	openshift-assisted/assisted-installer-ui	presubmit	Presubmit changed
pull-ci-openshift-assisted-assisted-installer-ui-release-5.0-e2e-agent-compact-ipv4-iso-no-registry	openshift-assisted/assisted-installer-ui	presubmit	Presubmit changed
pull-ci-openshift-assisted-assisted-installer-ui-release-5.1-e2e-agent-compact-ipv4-iso-no-registry	openshift-assisted/assisted-installer-ui	presubmit	Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[pawanpinjarkar]

/pj-rehearse auto-ack

[openshift-merge-bot]

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@pawanpinjarkar, pj-rehearse: failed to create rehearsal jobs ERROR:

failed waiting for prowjobs to finish: context deadline exceeded

If the problem persists, please contact Test Platform.