Skip to content

openstack-test: migrate CI config to OTE (openshift-tests-extension), 4.14-4.22 #81168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danchild wants to merge 1 commit into
base: main
Choose a base branch
from
+114 −36
Open

openstack-test: migrate CI config to OTE (openshift-tests-extension), 4.14-4.22 #81168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.14.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
binary_build_commands: go build -o /bin/openstack-tests ./cmd/openshift-tests
binary_build_commands: |
go build -o /bin/openstack-tests ./cmd/openshift-tests && \
make tests-ext-build && \
gzip -c bin/openstack-test-tests-ext > /usr/bin/openstack-test-tests-ext.gz
Comment on lines +1 to +4

@coderabbitai coderabbitai Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify the tests-ext-build make target exists on each upstream openstack-test release branch.
for b in release-4.14 release-4.15 release-4.16 release-4.17 release-4.18 release-4.19 release-4.20 release-4.21 release-4.22; do
  echo "=== $b ==="
  content=$(gh api "repos/openshift/openstack-test/contents/Makefile?ref=${b}" --jq '.content' 2>/dev/null | base64 -d 2>/dev/null)
  if [ -z "$content" ]; then
    echo "Makefile not found on $b"
    continue
  fi
  echo "$content" | grep -nE 'tests-ext-build|openstack-test-tests-ext' || echo "tests-ext-build target NOT found"
done

Repository: openshift/release

Length of output: 641

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect upstream openstack-test Makefiles and surrounding build inputs for the
# release branches mentioned in the review comment.
for b in release-4.14 release-4.15 release-4.16 release-4.17 release-4.18 release-4.19 release-4.20 release-4.21 release-4.22; do
  echo "=== $b ==="
  api="repos/openshift/openstack-test/contents"
  for path in Makefile makefile GNUmakefile hack/Makefile hack/makefile .; do
    :
  done

  # Try common make-related files first.
  for path in Makefile GNUmakefile hack/Makefile hack/lib.sh; do
    data=$(gh api "${api}/${path}?ref=${b}" --jq '.content // empty' 2>/dev/null | base64 -d 2>/dev/null || true)
    if [ -n "${data}" ]; then
      printf '%s\n' "$data" | grep -nE 'tests-ext-build|openstack-test-tests-ext|binary_build_commands|go build -o /bin/openstack-tests' || true
    fi
  done

  # Look for any repository paths mentioning tests-ext-build.
  tree=$(gh api "repos/openshift/openstack-test/git/trees/${b}?recursive=1" 2>/dev/null || true)
  if [ -n "$tree" ]; then
    printf '%s\n' "$tree" | jq -r '.tree[]?.path' | grep -n 'tests-ext-build\|openstack-test-tests-ext' || true
  fi
done

Repository: openshift/release

Length of output: 344

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect upstream openstack-test Makefiles and surrounding build inputs for the
# release branches mentioned in the review comment.
for b in release-4.14 release-4.15 release-4.16 release-4.17 release-4.18 release-4.19 release-4.20 release-4.21 release-4.22; do
  echo "=== $b ==="
  api="repos/openshift/openstack-test/contents"

  # Try common make-related files first.
  for path in Makefile GNUmakefile hack/Makefile hack/lib.sh; do
    data=$(gh api "${api}/${path}?ref=${b}" --jq '.content // empty' 2>/dev/null | base64 -d 2>/dev/null || true)
    if [ -n "${data}" ]; then
      printf '%s\n' "$data" | grep -nE 'tests-ext-build|openstack-test-tests-ext|binary_build_commands|go build -o /bin/openstack-tests' || true
    fi
  done

  # Look for any repository paths mentioning tests-ext-build.
  tree=$(gh api "repos/openshift/openstack-test/git/trees/${b}?recursive=1" 2>/dev/null || true)
  if [ -n "$tree" ]; then
    printf '%s\n' "$tree" | jq -r '.tree[]?.path' | grep -n 'tests-ext-build\|openstack-test-tests-ext' || true
  fi
done

Repository: openshift/release

Length of output: 344

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect upstream openstack-test Makefiles and surrounding build inputs for the
# release branches mentioned in the review comment.
for b in release-4.14 release-4.15 release-4.16 release-4.17 release-4.18 release-4.19 release-4.20 release-4.21 release-4.22; do
  echo "=== $b ==="
  api="repos/openshift/openstack-test/contents"

  # Try common make-related files first.
  for path in Makefile GNUmakefile hack/Makefile hack/lib.sh; do
    data=$(gh api "${api}/${path}?ref=${b}" --jq '.content // empty' 2>/dev/null | base64 -d 2>/dev/null || true)
    if [ -n "${data}" ]; then
      printf '%s\n' "$data" | grep -nE 'tests-ext-build|openstack-test-tests-ext|binary_build_commands|go build -o /bin/openstack-tests' || true
    fi
  done

  # Look for any repository paths mentioning tests-ext-build.
  tree=$(gh api "repos/openshift/openstack-test/git/trees/${b}?recursive=1" 2>/dev/null || true)
  if [ -n "$tree" ]; then
    printf '%s\n' "$tree" | jq -r '.tree[]?.path' | grep -n 'tests-ext-build\|openstack-test-tests-ext' || true
  fi
done

Repository: openshift/release

Length of output: 344

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect upstream openstack-test Makefiles and surrounding build inputs for the
# release branches mentioned in the review comment.
for b in release-4.14 release-4.15 release-4.16 release-4.17 release-4.18 release-4.19 release-4.20 release-4.21 release-4.22; do
  echo "=== $b ==="
  api="repos/openshift/openstack-test/contents"

  # Try common make-related files first.
  for path in Makefile GNUmakefile hack/Makefile hack/lib.sh; do
    data=$(gh api "${api}/${path}?ref=${b}" --jq '.content // empty' 2>/dev/null | base64 -d 2>/dev/null || true)
    if [ -n "${data}" ]; then
      printf '%s\n' "$data" | grep -nE 'tests-ext-build|openstack-test-tests-ext|binary_build_commands|go build -o /bin/openstack-tests' || true
    fi
  done

  # Look for any repository paths mentioning tests-ext-build.
  tree=$(gh api "repos/openshift/openstack-test/git/trees/${b}?recursive=1" 2>/dev/null || true)
  if [ -n "$tree" ]; then
    printf '%s\n' "$tree" | jq -r '.tree[]?.path' | grep -n 'tests-ext-build\|openstack-test-tests-ext' || true
  fi
done

Repository: openshift/release

Length of output: 344

Remove the tests-ext-build step
openshift/openstack-test does not define tests-ext-build or produce bin/openstack-test-tests-ext on release-4.14 through release-4.22, so this build command will fail as written.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.14.yaml`
around lines 1 - 4, The binary build command for openshift/openstack-test
includes a nonexistent tests-ext-build step and references an artifact that is
not produced on the affected releases. Update the binary_build_commands block to
remove the make tests-ext-build invocation and any dependent gzip command for
bin/openstack-test-tests-ext, keeping only the valid build step(s) used by the
openshift-tests binary path.

build_root:
image_stream_tag:
name: release
Expand Down Expand Up @@ -30,7 +33,7 @@ resources:
memory: 200Mi
tests:
- as: build
commands: openstack-tests --help
commands: ./bin/openstack-test-tests-ext --help
container:
from: bin
- as: verify
Expand All @@ -43,7 +46,7 @@ tests:
env:
CONFIG_TYPE: minimal
test:
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-ccpmso
Expand All @@ -62,7 +65,7 @@ tests:
resources:
requests:
cpu: 100m
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-dualstack-techpreview
Expand All @@ -71,6 +74,9 @@ tests:
cluster_profile: openstack-hwoffload
env:
FEATURE_SET: TechPreviewNoUpgrade
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
zz_generated_metadata:
branch: release-4.14
Expand Down
17 changes: 13 additions & 4 deletions ci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.15.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
binary_build_commands: go build -o /bin/openstack-tests ./cmd/openshift-tests
binary_build_commands: |
go build -o /bin/openstack-tests ./cmd/openshift-tests && \
make tests-ext-build && \
gzip -c bin/openstack-test-tests-ext > /usr/bin/openstack-test-tests-ext.gz
build_root:
image_stream_tag:
name: release
Expand Down Expand Up @@ -30,7 +33,7 @@ resources:
memory: 200Mi
tests:
- as: build
commands: openstack-tests --help
commands: ./bin/openstack-test-tests-ext --help
container:
from: bin
- as: verify
Expand All @@ -43,7 +46,7 @@ tests:
env:
CONFIG_TYPE: minimal
test:
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-ccpmso
Expand All @@ -62,13 +65,16 @@ tests:
resources:
requests:
cpu: 100m
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-dualstack
optional: true
steps:
cluster_profile: openstack-hwoffload
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
- always_run: false
as: e2e-openstack-dualstack-v6primary
Expand All @@ -77,6 +83,9 @@ tests:
cluster_profile: openstack-hwoffload
env:
CONFIG_TYPE: dualstack-v6primary
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
zz_generated_metadata:
branch: release-4.15
Expand Down
17 changes: 13 additions & 4 deletions ci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.16.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
binary_build_commands: go build -o /bin/openstack-tests ./cmd/openshift-tests
binary_build_commands: |
go build -o /bin/openstack-tests ./cmd/openshift-tests && \
make tests-ext-build && \
gzip -c bin/openstack-test-tests-ext > /usr/bin/openstack-test-tests-ext.gz
build_root:
from_repository: true
use_build_cache: true
Expand Down Expand Up @@ -28,7 +31,7 @@ resources:
memory: 200Mi
tests:
- as: build
commands: openstack-tests --help
commands: ./bin/openstack-test-tests-ext --help
container:
from: bin
- as: verify
Expand All @@ -41,7 +44,7 @@ tests:
env:
CONFIG_TYPE: minimal
test:
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-ccpmso
Expand All @@ -60,13 +63,16 @@ tests:
resources:
requests:
cpu: 100m
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-dualstack
optional: true
steps:
cluster_profile: openstack-hwoffload
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
- always_run: false
as: e2e-openstack-dualstack-v6primary
Expand All @@ -75,6 +81,9 @@ tests:
cluster_profile: openstack-hwoffload
env:
CONFIG_TYPE: dualstack-v6primary
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
zz_generated_metadata:
branch: release-4.16
Expand Down
17 changes: 13 additions & 4 deletions ci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.17.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
binary_build_commands: go build -o /bin/openstack-tests ./cmd/openshift-tests
binary_build_commands: |
go build -o /bin/openstack-tests ./cmd/openshift-tests && \
make tests-ext-build && \
gzip -c bin/openstack-test-tests-ext > /usr/bin/openstack-test-tests-ext.gz
build_root:
from_repository: true
use_build_cache: true
Expand Down Expand Up @@ -28,7 +31,7 @@ resources:
memory: 200Mi
tests:
- as: build
commands: openstack-tests --help
commands: ./bin/openstack-test-tests-ext --help
container:
from: bin
- as: verify
Expand All @@ -41,7 +44,7 @@ tests:
env:
CONFIG_TYPE: minimal
test:
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-ccpmso
Expand All @@ -60,13 +63,16 @@ tests:
resources:
requests:
cpu: 100m
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-dualstack
optional: true
steps:
cluster_profile: openstack-hwoffload
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
- always_run: false
as: e2e-openstack-dualstack-v6primary
Expand All @@ -75,6 +81,9 @@ tests:
cluster_profile: openstack-hwoffload
env:
CONFIG_TYPE: dualstack-v6primary
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
zz_generated_metadata:
branch: release-4.17
Expand Down
17 changes: 13 additions & 4 deletions ci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.18.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
binary_build_commands: go build -o /bin/openstack-tests ./cmd/openshift-tests
binary_build_commands: |
go build -o /bin/openstack-tests ./cmd/openshift-tests && \
make tests-ext-build && \
gzip -c bin/openstack-test-tests-ext > /usr/bin/openstack-test-tests-ext.gz
build_root:
from_repository: true
use_build_cache: true
Expand Down Expand Up @@ -28,7 +31,7 @@ resources:
memory: 200Mi
tests:
- as: build
commands: openstack-tests --help
commands: ./bin/openstack-test-tests-ext --help
container:
from: bin
- as: verify
Expand All @@ -41,7 +44,7 @@ tests:
env:
CONFIG_TYPE: minimal
test:
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-ccpmso
Expand All @@ -60,13 +63,16 @@ tests:
resources:
requests:
cpu: 100m
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-dualstack
optional: true
steps:
cluster_profile: openstack-hwoffload
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
- always_run: false
as: e2e-openstack-dualstack-v6primary
Expand All @@ -75,6 +81,9 @@ tests:
cluster_profile: openstack-hwoffload
env:
CONFIG_TYPE: dualstack-v6primary
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
zz_generated_metadata:
branch: release-4.18
Expand Down
17 changes: 13 additions & 4 deletions ci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.19.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
binary_build_commands: go build -o /bin/openstack-tests ./cmd/openshift-tests
binary_build_commands: |
go build -o /bin/openstack-tests ./cmd/openshift-tests && \
make tests-ext-build && \
gzip -c bin/openstack-test-tests-ext > /usr/bin/openstack-test-tests-ext.gz
build_root:
from_repository: true
use_build_cache: true
Expand Down Expand Up @@ -28,7 +31,7 @@ resources:
memory: 200Mi
tests:
- as: build
commands: openstack-tests --help
commands: ./bin/openstack-test-tests-ext --help
container:
from: bin
- as: verify
Expand All @@ -41,7 +44,7 @@ tests:
env:
CONFIG_TYPE: minimal
test:
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-ccpmso
Expand All @@ -61,13 +64,16 @@ tests:
requests:
cpu: 100m
timeout: 7h0m0s
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-dualstack
optional: true
steps:
cluster_profile: openstack-hwoffload
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
- always_run: false
as: e2e-openstack-dualstack-v6primary
Expand All @@ -76,6 +82,9 @@ tests:
cluster_profile: openstack-hwoffload
env:
CONFIG_TYPE: dualstack-v6primary
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
zz_generated_metadata:
branch: release-4.19
Expand Down
17 changes: 13 additions & 4 deletions ci-operator/config/openshift/openstack-test/openshift-openstack-test-release-4.20.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
binary_build_commands: go build -o /bin/openstack-tests ./cmd/openshift-tests
binary_build_commands: |
go build -o /bin/openstack-tests ./cmd/openshift-tests && \
make tests-ext-build && \
gzip -c bin/openstack-test-tests-ext > /usr/bin/openstack-test-tests-ext.gz
build_root:
from_repository: true
use_build_cache: true
Expand Down Expand Up @@ -28,7 +31,7 @@ resources:
memory: 200Mi
tests:
- as: build
commands: openstack-tests --help
commands: ./bin/openstack-test-tests-ext --help
container:
from: bin
- as: verify
Expand All @@ -41,7 +44,7 @@ tests:
env:
CONFIG_TYPE: minimal
test:
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-ccpmso
Expand All @@ -61,13 +64,16 @@ tests:
requests:
cpu: 100m
timeout: 7h0m0s
- ref: openstack-test-openstack
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-openstack-dualstack
optional: true
steps:
cluster_profile: openstack-hwoffload
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
- always_run: false
as: e2e-openstack-dualstack-v6primary
Expand All @@ -76,6 +82,9 @@ tests:
cluster_profile: openstack-hwoffload
env:
CONFIG_TYPE: dualstack-v6primary
test:
- ref: openshift-e2e-test
- ref: openstack-test-openstack-ote
workflow: openshift-e2e-openstack-dualstack
zz_generated_metadata:
branch: release-4.20
Expand Down
Loading