make jluhrsen as approver for core-networking projects by jluhrsen · Pull Request #81172 · openshift/release

jluhrsen · 2026-06-27T01:08:40Z

add's ignore for core-networking projects to the periodic-prow-auto-owners job
makes jluhrsen approver/reviewer for all core-networking projects

Summary by CodeRabbit

Updated core-networking CI ownership so jluhrsen is recognized as an approver, and in most cases also a reviewer, across the affected OpenShift component repositories. This adjusts who can review and approve CI/config changes for the listed projects: cloud-network-config-controller, cluster-network-operator, egress-router-cni, ingress-node-firewall, network-tools, network.offline_migration_sdn_to_ovnk, ovn-kubernetes, and sdn.

Also added these core-networking repositories to the periodic-prow-auto-owners job’s ignore list so auto-owners processing will skip them.

The ignore-repo arguments in the periodic-prow-auto-owners job in ci-operator/jobs/infra-periodics.yaml are now sorted alphabetically to improve readability and maintainability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Add the following core-networking repositories to the periodic-prow-auto-owners ignore-repo list in alphabetical order: - openshift/cloud-network-config-controller - openshift/cluster-network-operator - openshift/egress-router-cni - openshift/ingress-node-firewall - openshift/network-tools - openshift/network.offline_migration_sdn_to_ovnk - openshift/ovn-kubernetes - openshift/sdn Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Add jluhrsen as both approver and reviewer to the OWNERS files for the following core-networking repositories: - ci-operator/config/openshift/cloud-network-config-controller - ci-operator/config/openshift/cluster-network-operator - ci-operator/config/openshift/egress-router-cni - ci-operator/config/openshift/ingress-node-firewall - ci-operator/config/openshift/network-tools - ci-operator/config/openshift/network.offline_migration_sdn_to_ovnk - ci-operator/config/openshift/ovn-kubernetes - ci-operator/config/openshift/sdn Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

coderabbitai · 2026-06-27T01:09:15Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c3e3d00d-ef1a-41e6-8cf8-dc0f4652b468

📥 Commits

Reviewing files that changed from the base of the PR and between 0041e66 and e413320.

⛔ Files ignored due to path filters (1)

ci-operator/jobs/infra-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (8)

ci-operator/config/openshift/cloud-network-config-controller/OWNERS
ci-operator/config/openshift/cluster-network-operator/OWNERS
ci-operator/config/openshift/egress-router-cni/OWNERS
ci-operator/config/openshift/ingress-node-firewall/OWNERS
ci-operator/config/openshift/network-tools/OWNERS
ci-operator/config/openshift/network.offline_migration_sdn_to_ovnk/OWNERS
ci-operator/config/openshift/ovn-kubernetes/OWNERS
ci-operator/config/openshift/sdn/OWNERS

Walkthrough

Several OpenShift network-related OWNERS files were updated to add jluhrsen to approvers, and in some files to reviewers as well.

Changes

OWNERS membership updates

Layer / File(s)	Summary
Approver additions `ci-operator/config/openshift/cloud-network-config-controller/OWNERS`, `ci-operator/config/openshift/egress-router-cni/OWNERS`, `ci-operator/config/openshift/network-tools/OWNERS`	`jluhrsen` is added to the approvers list in three OWNERS files.
Approver and reviewer additions `ci-operator/config/openshift/cluster-network-operator/OWNERS`, `ci-operator/config/openshift/ingress-node-firewall/OWNERS`, `ci-operator/config/openshift/network.offline_migration_sdn_to_ovnk/OWNERS`, `ci-operator/config/openshift/ovn-kubernetes/OWNERS`, `ci-operator/config/openshift/sdn/OWNERS`	`jluhrsen` is added to approvers in five OWNERS files and to reviewers in the same set, with existing reviewer entries adjusted where present.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: adding jluhrsen to core-networking OWNERS as an approver, though it omits reviewer and auto-owners updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only updates OWNERS files; no Ginkgo test titles or test code were added or modified.
Test Structure And Quality	✅ Passed	PR only touches OWNERS files for core-networking repos; no Ginkgo/test code changed, so the test-quality rules don’t apply.
Microshift Test Compatibility	✅ Passed	No Ginkgo tests were added; the diff only updates OWNERS files and a periodic job ignore list, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only updates OWNERS metadata for core-networking repos; no Ginkgo/e2e test files or SNO-sensitive test code was added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only OWNERS metadata and CI job config changed; no deployment manifests/controllers with affinity, nodeSelector, replicas, or PDBs were modified.
Ote Binary Stdout Contract	✅ Passed	Only OWNERS metadata changed; no process-level binaries, init hooks, or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only updates OWNERS/job metadata; no new Ginkgo e2e tests or IPv4/external connectivity code was added in the touched files.
No-Weak-Crypto	✅ Passed	Only OWNERS membership changes were added; no crypto code, weak algorithms, or secret comparisons appear in the changed files.
Container-Privileges	✅ Passed	Only OWNERS files changed; no container/K8s manifests or privilege settings (privileged, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation) were added.
No-Sensitive-Data-In-Logs	✅ Passed	Commit only updates OWNERS entries to add jluhrsen; no logging code or sensitive data appears in the diff.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-06-27T01:09:29Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-06-27T01:11:40Z

[REHEARSALNOTIFIER]
@jluhrsen: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

jluhrsen · 2026-06-27T02:06:48Z

/test yamllint

openshift-ci · 2026-06-27T02:09:58Z

@jluhrsen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jluhrsen and others added 3 commits June 26, 2026 17:55

openshift-ci Bot requested review from abhat and arkadeepsen June 27, 2026 01:09

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

make jluhrsen as approver for core-networking projects#81172

make jluhrsen as approver for core-networking projects#81172
jluhrsen wants to merge 3 commits into
openshift:mainfrom
jluhrsen:jluhrsen-as-approver

jluhrsen commented Jun 27, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 27, 2026 •

edited

Loading

Uh oh!

openshift-ci Bot commented Jun 27, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 27, 2026

Uh oh!

jluhrsen commented Jun 27, 2026

Uh oh!

openshift-ci Bot commented Jun 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jluhrsen commented Jun 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-ci Bot commented Jun 27, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 27, 2026

Uh oh!

jluhrsen commented Jun 27, 2026

Uh oh!

openshift-ci Bot commented Jun 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jluhrsen commented Jun 27, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 27, 2026 •

edited

Loading