Skip to content

Use develop branch for flutter_lib #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DmitryNesterenok wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use develop branch for flutter_lib #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e928a0
Use develop branch for flutter_lib
DmitryNesterenok Oct 28, 2025
76bbbe2
Use develop branch when we don't pass branch
DmitryNesterenok Oct 28, 2025
7733417
merge
DmitryNesterenok Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions setup-dartwing-project.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ clone_or_update_repo() {
local repo_name=$1
local repo_url=$2
local target_dir=$3
local branch=${4:-$DEFAULT_BRANCH}
local branch=${4:-develop}
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Hardcoding 'develop' as the default branch removes flexibility. Consider using a configuration variable (e.g., ${DEFAULT_BRANCH:-develop}) to allow overriding the default while maintaining the new behavior.

Suggested change
local branch=${4:-develop}
local branch=${4:-${DEFAULT_BRANCH:-develop}}

Copilot uses AI. Check for mistakes.

if [ -d "$target_dir" ]; then
if [ -d "$target_dir/.git" ]; then
Expand Down Expand Up @@ -115,8 +115,7 @@ echo ""
# Clone or update repositories
clone_or_update_repo "Flutter App" "$APP_REPO" "app" "$BRANCH"
clone_or_update_repo "Gatekeeper Service" "$GATEKEEPER_REPO" "gatekeeper" "$BRANCH"
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The Flutter Library now uses a different branching strategy than the App and Gatekeeper repositories. Consider adding a comment explaining why the Flutter Library uses 'develop' while others use '$BRANCH' to improve code clarity.

Suggested change
clone_or_update_repo "Gatekeeper Service" "$GATEKEEPER_REPO" "gatekeeper" "$BRANCH"
clone_or_update_repo "Gatekeeper Service" "$GATEKEEPER_REPO" "gatekeeper" "$BRANCH"
# Note: The Flutter Library uses a different branching strategy and defaults to its own 'develop' branch.
# This is intentional, as the library's release workflow is managed separately from the App and Gatekeeper.

Copilot uses AI. Check for mistakes.
clone_or_update_repo "Flutter Library" "$LIB_REPO" "lib" "$BRANCH"

clone_or_update_repo "Flutter Library" "$LIB_REPO" "lib"
echo ""
print_status "All repositories cloned/updated successfully!"

Expand Down Expand Up @@ -153,4 +152,4 @@ echo "2. Check the app/ directory for the Flutter application"
echo "3. Check the gatekeeper/ directory for the backend service"
echo "4. Check the lib/ directory for shared Flutter components"
echo ""
echo "To update all components in the future, run this script again."
echo "To update all components in the future, run this script again."