Conversation
|
@RichardLitt you're looking for @khos2ow ... 😄 |
|
@khosrow but you can become of the maintainers too! 😉 |
|
@RichardLitt hmm, it is in the guide, may be we need to change the wording. https://github.com/opensourcecities/toronto/blob/master/CONTRIBUTING.md#organization |
|
HA! My bad, @khosrow. :) Was using my memory to remember the spelling. |
|
Essentially you need to execute |
RichardLitt
force-pushed
the
feat/tunnelbear
branch
from
9a08e34 to
a5a231f
Compare
Link issue by
|
| Line | Status | Link |
|---|---|---|
| 125 | Error | https://bentomiso.com/ Connection timed out - connect(2) for "bentomiso.com" port 443 |
Generated by 🚫 Danger
khos2ow
left a comment
khos2ow
left a comment
There was a problem hiding this comment.
LGTM, I only had one small comment.
| - [Inclusive Design Institute](https://github.com/inclusive-design) - R&D for inclusiveness and diversity. [Website](https://inclusivedesign.ca/) | ||
| - [The Heap](https://github.com/the-heap/) - Cultivated + managed community projects especially welcome to new contributors. | ||
| - [Toronto Mesh](https://github.com/tomeshnet) - Community mesh network in Toronto. [Website](https://tomesh.net) | ||
| - [yorkulibraries](https://github.com/yorkulibraries) [Website](www.library.yorku.ca) |
There was a problem hiding this comment.
I would say change www.library.yorku.ca to https://www.library.yorku.ca/web/ - as there is a 301 redirect - to prevent awesome_bot complains in the future.
There was a problem hiding this comment.
I grabbed it from the GitHub profile page. I would just allow 301s on awesome-bot, it's not a blocking error.
There was a problem hiding this comment.
Great. I would say proceed with this PR and if in following days the issue with https://bentomiso.com/ wasn't resolved we can remove it.
There was a problem hiding this comment.
Actually if you don't remove the problematic URL, GH pages won't get updated! So you might want to remove it in this PR and ping the owner in an issue.
There was a problem hiding this comment.
Why won't GH pages get updated?
There was a problem hiding this comment.
Because it's being updated in Travis after awesome_bot finishes, and if it fails the whole pipeline fails.
There was a problem hiding this comment.
Compare the last two commits in master branch for example.
There was a problem hiding this comment.
I'd rather our build didn't depend upon other websites that way. It seems awfully brittle.
|
I usually , when awesome_bot fails, run it again after couple of minutes to see if there was a network glitch on failed sites or not and occasionally remove them. But for example this needs to be fixed as it is a legitimate error: |
4 participants
@khosrow, is there a way for me to automtically generate these templates? It wasn't clear in the contribute guide, and manually adding Markdown files is annoying. I don't want to manually add details for dozens of organizations. :/