fix: 删除 CLA 更新后的立即通知，统一走定时器扫描#485
Conversation
大社区场景下立即触发 500 封限制无实际价值，定时器中午/午夜各扫一轮即可。 SetPendingCLAForLink 保留，持久化通知标记，定时器扫到后自动发送。
Welcome To opensourceways CommunityHey @JavaPythonAIForBAT , thanks for your contribution to the community. Bot Usage ManualI'm the Bot here serving you. You can find the instructions on how to interact with me at Here . That means you can comment below every pull request or issue to trigger Bot Commands. Contact GuideIf you have any questions, please contact the SIG: infratructure , |
CLA Signature PassJavaPythonAIForBAT, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
Linking Issue Notice@JavaPythonAIForBAT , the pull request must be linked to at least one issue. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the unused import of the "watch" package and the call to "watch.TriggerNotify()" within the "Update" method of "claService" in "signing/app/cla.go". There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| logs.Error("set pending CLA for link failed: %s, err: %v", cmd.LinkId, err) | ||
| } | ||
|
|
||
| watch.TriggerNotify() |
- 删除 TriggerNotify() 函数 - 删除 corpTrigger/individualTrigger 通道字段及初始化 - 删除 watcher goroutine 中的 trigger select case - 通知统一走定时器（12:00 + 0:00），不再保留即时触发通道
|
|||||||||||||||
CLA Signature PassJavaPythonAIForBAT, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
|
|||||||||||||||
CLA Signature PassJavaPythonAIForBAT, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
|
|||||||||||||||
3 participants
Summary
原因
大社区场景下立即触发受 batch_size=500 限制只能发 500 封，剩余仍需等定时器，立即无实际意义。删除后统一走定时器，逻辑更简单可靠。