Add charmhub-lp-tool-osci-sync#261
Conversation
freyes
force-pushed
the
charm-lp-recipe-sync
branch
from
558b13b to
633c1ce
Compare
freyes
force-pushed
the
charm-lp-recipe-sync
branch
from
633c1ce to
0fd5aa9
Compare
charmhub-lp-tool-osci-sync job takes care of installing charmhub-lp-tools (via pip) and running `charmhub-lp-tool osci-sync` which reads osci.yaml to get the desired charmcraft version to be used when building the charm and update the Launchpad charm build recipe. Introduces a new secret named "launchpad_token" which contains a token associated to a uosci-testing-bot[0] [0] https://launchpad.net/~uosci-testing-bot
This change fixes a warning thrown when running ansible-lint: Warning: : Skipping plugin (/home/runner/work/zosci-config/zosci- config/.tox/linters/lib/python3.8/site- packages/ansible/plugins/filter/mathstuff.py) as it seems to be invalid: cannot import name 'environmentfilter' from 'jinja2.filters' (/home/runner/work/zosci- config/zosci-config/.tox/linters/lib/python3.8/site-packages/jinja2/filters.py)
freyes
force-pushed
the
charm-lp-recipe-sync
branch
from
0fd5aa9 to
4d3b364
Compare
| #- tox-py310 | ||
| promote: | ||
| jobs: | ||
| - charmhub-osci-sync |
There was a problem hiding this comment.
something I'm not sure if this is the right place to trigger the job, I don't know if there should be a new check job that each charm needs/should opt-in.
There was a problem hiding this comment.
Promote feels like the place to sync between the code and LP/charmhub; I wouldn't want it in check as that happens in every code submission
ajkavanagh
left a comment
ajkavanagh
left a comment
There was a problem hiding this comment.
I'm generally +1 on this, but I admit to not being absolutely sure that it will work as we intend. At present, 'zed' unit jobs on zosci would do the sync when the associated review is merged; at least I think that is what it will do.
|
On Mon, 2023-03-27 at 05:30 -0700, Chris MacNaughton wrote:
@ChrisMacNaughton commented on this pull request.
In zuul.d/project-templates.yaml:
> @@ -330,6 +330,9 @@
# NOTE(icey) BUT REALLY, DO NOT ENABLE THE FOLLOWING UNTIL YOU KNOW WE CAN
# RUN A 3.10 JOB ON ZOSCI.
#- tox-py310
+ promote:
+ jobs:
+ - charmhub-osci-sync
Promote feels like the place to sync between the code and LP/charmhub; I wouldn't want it in check
as that happens in every code submission
maybe run this job only on changes to the osci.yaml file?, we can expand the list of file if `osci-
sync` reacts to changes in other paths.
|
Hmm; then it wouldn't auto-overwrite changes that someone had mistakenly done manually to launchpad. I'd much rather that the successful build and test on zOSCI then reflects the charmcraft version on launchpad automatically. |
|
@freyes is there anything else we need to check before landing this. It would be really good to move to this model of a single source of truth being in the repo of the charm. Then we can rip it out of charmed-openstack-info to lower potential confusion. |
3 participants
charmhub-lp-tool-osci-sync job takes care of installing charmhub-lp-tools (via pip) and
running
charmhub-lp-tool osci-syncwhich reads osci.yaml to get the desiredcharmcraft version to be used when building the charm and update the
Launchpad charm build recipe.
Introduces a new secret named "launchpad_token" which contains a token
associated to a uosci-testing-bot[0]
Related-PR: openstack-charmers/charmhub-lp-tools#28
[0] https://launchpad.net/~uosci-testing-bot