Add edpm module with unstructured NodeSet secret hash check#692
Merged
Conversation
Add a new modules/edpm package that checks whether OpenStackDataPlaneNodeSet deployed secret hashes are in sync with current cluster secrets. Uses an unstructured client to avoid importing dataplane API types, allowing consumers like infra-operator to drop the heavyweight openstack-operator/api dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Ship a minimal OpenStackDataPlaneNodeSet CRD in the test module so operators using the edpm package can load it in envtest without importing openstack-operator/api. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
abays
reviewed
May 12, 2026
abays
approved these changes
May 12, 2026
Contributor
abays
left a comment
abays
left a comment
There was a problem hiding this comment.
This seems good to me, as it avoids the dreaded circular dependency problem
/lgtm
stuggi
reviewed
May 12, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new modules/edpm package that checks whether OpenStackDataPlaneNodeSet deployed secret hashes are in sync with current cluster secrets. Uses an unstructured client to avoid importing dataplane API types, allowing consumers like infra-operator to drop the heavyweight openstack-operator/api dependency.