Skip to content

Enable OKP by default#11

Merged
umago merged 2 commits into
openstack-k8s-operators:mainfrom
umago:okp-by-default
Jul 8, 2026
Merged

Enable OKP by default#11
umago merged 2 commits into
openstack-k8s-operators:mainfrom
umago:okp-by-default

Conversation

@umago

@umago umago commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • OKP is now enabled by default.
  • Drop the okp-configuration kuttl test and include OKP as part of the assertion of the other existing tests.
  • Default OKPRagOnly to true

@umago umago force-pushed the okp-by-default branch from e1fd1a4 to 64363a6 Compare July 6, 2026 14:59
@umago

umago commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

Tested locally. Kuttl tests are passing as well:

=== NAME  kuttl
    harness.go:403: run tests finished
    harness.go:510: cleaning up
    harness.go:567: removing temp folder: ""
--- PASS: kuttl (333.55s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/basic-openstack-lightspeed-configuration (99.25s)
        --- PASS: kuttl/harness/update-openstacklightspeed (136.90s)
        --- PASS: kuttl/harness/persistent-database (97.38s)
PASS

omkarjoshi0304
omkarjoshi0304 reviewed Jul 7, 2026
View reviewed changes
Comment thread internal/controller/okp_reconciler.go
@umago umago force-pushed the okp-by-default branch from 64363a6 to a59ac6b Compare July 7, 2026 15:49
@umago umago marked this pull request as draft July 8, 2026 09:13
@umago umago force-pushed the okp-by-default branch from 36e23f1 to 088aca5 Compare July 8, 2026 09:31
@umago umago marked this pull request as ready for review July 8, 2026 09:43
@umago

umago commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

Ran kuttl after changes:

=== NAME  kuttl
    harness.go:403: run tests finished
    harness.go:510: cleaning up
    harness.go:567: removing temp folder: ""
--- PASS: kuttl (334.64s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/basic-openstack-lightspeed-configuration (99.20s)
        --- PASS: kuttl/harness/update-openstacklightspeed (136.94s)
        --- PASS: kuttl/harness/persistent-database (98.47s)
PASS

@umago umago marked this pull request as draft July 8, 2026 12:44
@umago umago force-pushed the okp-by-default branch 3 times, most recently from c882145 to 967c4c3 Compare July 8, 2026 13:00
umago added 2 commits July 8, 2026 14:13
@umago
Enable OKP by default
9065079 
* OKP is now enabled by default.
* Drop the okp-configuration kuttl test and include OKP as part of the
  assertion of the other existing tests.

Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
@umago
Default OKPRagOnly to true
43e0b82 
Change OKPRagOnly default to true, making OKP the only RAG source by
default.

Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
@umago umago force-pushed the okp-by-default branch from 967c4c3 to 43e0b82 Compare July 8, 2026 13:13
@umago umago marked this pull request as ready for review July 8, 2026 13:22
@umago

umago commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

Conflicts sorted, kuttl tests are now passing again:

=== NAME  kuttl
    harness.go:403: run tests finished
    harness.go:510: cleaning up
    harness.go:567: removing temp folder: ""
--- PASS: kuttl (452.87s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/basic-openstack-lightspeed-configuration (99.10s)
        --- PASS: kuttl/harness/update-openstacklightspeed (256.39s)
        --- PASS: kuttl/harness/persistent-database (97.36s)
PASS

@umago umago requested a review from lpiwowar July 8, 2026 13:44
Akrog
Akrog approved these changes Jul 8, 2026
View reviewed changes

@Akrog Akrog left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

lpiwowar
lpiwowar approved these changes Jul 8, 2026
View reviewed changes

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@umago

umago commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks @Akrog @lpiwowar! Two approvals, I will merge this. The /lgtm does not work yet because prow isn't yet setup for these new repos. Omkar is working on it.

@umago umago merged commit 9b0ffe8 into openstack-k8s-operators:main Jul 8, 2026
3 checks passed
@umago umago deleted the okp-by-default branch July 8, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omkarjoshi0304 omkarjoshi0304 omkarjoshi0304 left review comments
@Akrog Akrog Akrog approved these changes
@lpiwowar lpiwowar lpiwowar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@umago @Akrog @lpiwowar @omkarjoshi0304