Remove EnableOCPRAG and OCPRAGVersionOverride#14
Merged
openshift-merge-bot[bot] merged 1 commit intoJul 10, 2026
Merged
Conversation
Collaborator
|
/ok-to-test |
Collaborator
|
nit: Found thanks to Claude. Otherwise LGTM:) [1] |
With the introduction of OKP the EnableOCPRAG and OCPRAGVersionOverride configuration options are no longer needed. This change remove all code related to EnableOCPRAG and OCPRAGVersionOverride, including the associated conditions, status field, shell script arguments, etc... The generic OCP version helper methods such as DetectOCPVersion and ParseMajorMinorVersion are retained as they are still used by the OKP chunk filter query and console image selection. Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
Collaborator
Author
Oops! Missed that comment. Removing it too |
umago
force-pushed
the
remove-ocp-leftovers
branch
from
333fa10 to
83ca6ef
Compare
Collaborator
|
/lgtm |
lpiwowar
approved these changes
Jul 10, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 8fbb40a
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of OKP the EnableOCPRAG and OCPRAGVersionOverride configuration options are no longer needed. This change remove all code related to EnableOCPRAG and OCPRAGVersionOverride, including the associated conditions, status field, shell script arguments, etc...
The generic OCP version helper methods such as DetectOCPVersion and ParseMajorMinorVersion are retained as they are still used by the OKP chunk filter query and console image selection.