Skip to content

Govulncheck: Fix vulnerabilities and add CI checks#17

Merged
openshift-merge-bot[bot] merged 3 commits into
openstack-k8s-operators:mainfrom
umago:govulncheck
Jul 10, 2026
Merged

Govulncheck: Fix vulnerabilities and add CI checks#17
openshift-merge-bot[bot] merged 3 commits into
openstack-k8s-operators:mainfrom
umago:govulncheck

Conversation

@umago

@umago umago commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR includes the following:

  • Add govulncheck for vulnerability scanning. Run with make govulncheck.
  • Fix vulnerabilities from govulncheck
  • Add govulncheck GH workflow: Runs on pull requests and daily.

It requires bumping Go to version 1.25.0

umago added 2 commits July 10, 2026 15:22
@umago
Add govulncheck make target
09038bc 
Add govulncheck for vulnerability scanning. Run with `make govulncheck`.

Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
@umago
Fix vulnerabilities from govulncheck
45e4ef5 
Fixes all vulnerabilities found when running "make govulncheck".

Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
@openshift-ci openshift-ci Bot requested review from Akrog and lpiwowar July 10, 2026 14:56
@umago umago marked this pull request as draft July 10, 2026 15:02
@umago
Add govulncheck GH workflow
1246ea1 
Runs on pull requests and daily at 06:23 UTC. The idea is to catch newly
disclosed vulnerabilities in our code.

Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
@umago umago marked this pull request as ready for review July 10, 2026 15:08
umago
umago commented Jul 10, 2026
View reviewed changes
Comment thread go.mod
lpiwowar
lpiwowar approved these changes Jul 10, 2026
View reviewed changes

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Just thinking whether it is a problem in terms of consistency with other operators in openstack-k8s-operators/* namespace but I can not think of any reason why it should be a problem.

@openshift-ci openshift-ci Bot added the lgtm label Jul 10, 2026
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpiwowar, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@umago

umago commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

/lgtm

Just thinking whether it is a problem in terms of consistency with other operators in openstack-k8s-operators/* namespace but I can not think of any reason why it should be a problem.

100%!

I think it's better to be safe than consistently unsafe :D

@openshift-merge-bot openshift-merge-bot Bot merged commit 6973f5e into openstack-k8s-operators:main Jul 10, 2026
8 checks passed
@umago umago deleted the govulncheck branch July 10, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpiwowar lpiwowar lpiwowar approved these changes
@Akrog Akrog Awaiting requested review from Akrog

Assignees

@lpiwowar lpiwowar

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@umago @lpiwowar