don't assume any CSVs are installed#316
don't assume any CSVs are installed#316zzzeek wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
change ae93738 added the assumption that a CSV would be installed under operators.coreos.com/openstack-operator.openstack-operators, but this cannot be assumed. I run run-with-webhook with no csvs installed at all, so this check as well must only proceed with patch commands if CSV_NAME isn't blank.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zzzeek The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
just to clarify, the patch at ae93738 produces this output for me |
|
/retest-required |
|
/lgtm |
|
/retest-required |
|
@zzzeek: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
change ae93738 added the assumption that a CSV would be installed under
operators.coreos.com/openstack-operator.openstack-operators, but this cannot be assumed. I run run-with-webhook with no csvs installed at all, so this check as well must only proceed with patch commands if CSV_NAME isn't blank.