Add configurable probe timeouts to Galera CR#452
Open
zzzeek wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Open
Add configurable probe timeouts to Galera CR#452zzzeek wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
zzzeek wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
use lib-common ProbeConf as a starting base for Probe values, then apply values from the Galera.Spec into each ProbeConf. then create Probe objects from that. The lib-common CreateProbeSet function is hardcoded to HTTP probes, so we can't use the new features fully, so here we vendor our own createProbeFromConf function. we also create the ProbeConf with user-merged values up front so we have a mergeProbeConf function that resembles lib-common.probe.merge(). lib-common's library could have some more public API features added to address these cases. patch also includes validating webhooks w/ unit tests as well as a chainsaw test modeled after the qos test suite. References: OSPRH-29441
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zzzeek The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use lib-common ProbeConf as a starting base for Probe values, then apply values from the Galera.Spec into each ProbeConf. then create Probe objects from that.
The lib-common CreateProbeSet function is hardcoded to HTTP probes, so we can't use the new features fully, so here we vendor our own createProbeFromConf function. we also create the ProbeConf with user-merged values up front so we have a mergeProbeConf function
that resembles lib-common.probe.merge(). lib-common's library could
have some more public API features added to address these cases.
patch also includes validating webhooks w/ unit tests as well as a chainsaw test modeled after the qos test suite.
References: OSPRH-29441