api: add openStackServiceIdentity to Nova service and template specs

[amartyasinha]

Add optional OpenStackServiceIdentity (openstackService, serviceComponent) on NovaServiceBase and Nova/NovaCell *Template types for logical service/component identity.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amartyasinha
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/388a87e6269f4cb8b52e489bdddd9f64

✔️ openstack-meta-content-provider SUCCESS in 4h 00m 26s
✔️ nova-operator-kuttl SUCCESS in 52m 48s
❌ nova-operator-tempest-multinode FAILURE in 2h 19m 07s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 45m 06s

[amartyasinha]

recheck nova-operator-tempest-multinode

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a4a5fbbad68046babab46e48e54abc3b

✔️ openstack-meta-content-provider SUCCESS in 2h 49m 09s
❌ nova-operator-kuttl RETRY_LIMIT in 42m 29s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 21m 56s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 34m 46s

[gibizer]

I don't see the reason to make this API change.

[amartyasinha]

I don't see the reason to make this API change.

@gibizer In the initial draft, I did not make this API change. To get nova/api from NovaAPI value, I introduced groupSegmentAndKindSuffix function (check openstack-k8s-operators/lib-common#682), which would work as nova.openstack.org + NovaAPI → nova/api. @bogdando discouraged to split like this, and suggested to introduced new data type. If you think we should go with other way, kindly suggest.

Once the lib-common gets the ability to handle multi-segment path, then we can go with https://github.com/openstack-k8s-operators/nova-operator/pull/1096/changes.

If we decide to proceed with adding these new fields in the specs, then the order would be:

1. Add new specs to nova-operator (this PR)
2. Modify lib-common ongoing PR to take care of multi-segment path based on new spec fields util: Add MultiTemplateDir to support multi-segment path in template lib-common#682
3. Finally introduce MultiTemplateDir changes in nova-operator Use MultiTemplateDir for the support of multi-segment dir in template #1096

If we decide not to add new fields in the specs, then the order would be:

1. Find a way in lib-common to get the core service name and component's name (nova and api from NovaAPI). groupSegmentAndKindSuffix function in the PR util: Add MultiTemplateDir to support multi-segment path in template lib-common#682 is currently doing that.
2. Finally introduce MultiTemplateDir changes in nova-operator Use MultiTemplateDir for the support of multi-segment dir in template #1096

[amartyasinha]

Closing as we do not want to modify the specs.