[DNM] Placement integration v5#1105
Open
amartyasinha wants to merge 667 commits into
Open
Conversation
Resources created by the placement-operator are named based on the name of the PlacementAPI CR
Make sure that DeploymentReady condition is set back to False if the Deployment ReadyReplicas falls back to 0
Public/Internal service cert secrets and the CA bundle secret can be passed to configure httpd virtual hosts for tls termination. The certs are mounted to in var/lib/config-data/tls/certs/%s.crt|key and a CA bundle to /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem. Server cert and key are intended to be moved by kolla to /etc/pki/tls/certs|private. Depends-On: openstack-k8s-operators/lib-common#428 Signed-off-by: Veronika Fisarova <vfisarov@redhat.com>
Our intention is to track service operator and lib-common dependencies via pseudoversions. However renovate does not automatically bump from a tagged version (e.g. v0.3.0) to a newer but not tagged pseudoversion. So this patch does the manual bump. After this renovate will bump the newer pseduoversions.
These fields were redundant. Crashing pods can be debugged via oc debug. Implements: OSPRH-4290
Adapt to the new version by: * adding RBAC rules for MariaDBAccount manipulation * adding Own(MariaDBAccount) to detect status changes * separating PlacementAPI CR name from the schema and MariaDBDatabase/Account name * adapting test to simulate MariaDBAccount success * adapting to new DB hostnames due to the mariadb TLS feature
This change modifies how the operator is built to use the ubi9 base image and golang tool chain. A new GO_BUILD_EXTRA_ENV_ARGS build arg is added to the dockerfile to enable the build system to inject addtional parmaters. the default value enable dynmaic linking of glibc which is required for FIPS The prow_ci.env file is extended to enable fips checkign in the prow image build job to validate this change. The Makefile is extened to allow passing build args to docker-build
We only want to support the policy.yaml file passthrough for PlacementAPI The kolla config files are modified to move the supported files in place. Implements: OSPRH-2503
Signed-off-by: Brendan Shephard <bshephar@redhat.com>
This change updates the webhook functions to comply with the new standard for controller-runtime. Signed-off-by: Brendan Shephard <bshephar@redhat.com>
This change updates the manager intialisation to comply with the new controller-runtime schema. Signed-off-by: Brendan Shephard <bshephar@redhat.com>
This change fixes the Watches declarations to comply with the new controller-runtime standards Signed-off-by: Brendan Shephard <bshephar@redhat.com>
Signed-off-by: Brendan Shephard <bshephar@redhat.com>
…er-runtime Controller runtime update
…rators/revert-144-controller-runtime Revert "Controller runtime update"
This change updates the webhook functions to comply with the new standard for controller-runtime. Signed-off-by: Brendan Shephard <bshephar@redhat.com>
This change updates the manager intialisation to comply with the new controller-runtime schema. Signed-off-by: Brendan Shephard <bshephar@redhat.com>
The go.work file is generated by the CI environment which may have a higher Go version than the build image (go-toolset). This causes build failures when go.work references a Go version that the build image does not provide. Since the Dockerfile builds a single module, go.work is not needed and can be safely removed before building. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Import placement-operator codebase with all files placed in placement-import/ subdir. The history was re-written using git-filter-repo All 500+ commits from placement-operator are preserved to maintain full git history. This is a base to move from placement-import/ to multi-group structure in nova-operator.
Move placement business logic from placement-import/internal/placement to internal/placement/ to keep alongside nova business logic
Move webhook from placement-import/internal/webhook/v1beta1/ to internal/webhook/placement/v1beta1/
Move placement templates from placement-import/templates/placementapi/ to templates/placement/api/
reorganize placement test structure to match nova-operator patterns - moves functional tests to test/functional/placement/ - moves kuttl tests to test/kuttl/test-suites/placement/ - move kuttl-test.yaml as config.yaml in test suite director - updates test suite config with proper namespace and paths - Fixes symlinks to point to correct sample file locations
adds placement test suite with shared deps files symlinked from default/deps to maintain consistency across test suit.
Remove 'placement' prefix from filenames within placement directories to match existing naming conventions ex: placementapi_types.go → placement/api_types.go
Update all import paths in placement code from github.com/openstack-k8s-operators/placement-operator/api/v1beta1 to github.com/openstack-k8s-operators/nova-operator/api/placement/v1beta1 and github.com/openstack-k8s-operators/placement-operator/internal/placement github.com/openstack-k8s-operators/nova-operator/internal/placement package name update functional_test to placement_test
Update kustomization.yaml to include placement samples
Update controller-gen paths to process both nova and placement APIs
- Register PlacementAPI controller in cmd/main.go - Register PlacementAPI webhook in cmd/main.go - Add placement scheme and defaults initialization - Fix placement test paths after moving to test/functional/placement/ - Add placement API to test coverage in Makefile
Updated Makefile to include placement webhook paths in controller-gen
Adds getTemplateInstanceType in placement/common.go
Remove placement-import directory - all code has been moved Add generated files from 'make manifests
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amartyasinha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
amartyasinha
force-pushed
the
placement-integration-v5
branch
from
b54a701 to
df61745
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
amartyasinha
force-pushed
the
placement-integration-v5
branch
from
df61745 to
b54a701
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Contributor
Author
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Contributor
|
Based on the code, CI results, and my local testing, I’m a +1 once we are ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of #1101 for testing in openstack-operator