Application Credential support#364
Conversation
Deydra71
force-pushed
the
appcred-support
branch
from
6c8e2ac to
09e4eb3
Compare
Deydra71
force-pushed
the
appcred-support
branch
from
09e4eb3 to
2e641c2
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
mrkisaolamb
left a comment
mrkisaolamb
left a comment
There was a problem hiding this comment.
Other than these small comments, everything looks good. So once we land the keystone-operator changes, we should be ready to go with this patch as well. I don't see any issues with the update/upgrade path. The only thing worth adding might be a kuttl test with the new secret
Deydra71
force-pushed
the
appcred-support
branch
from
2e641c2 to
2ca02e9
Compare
Deydra71
force-pushed
the
appcred-support
branch
from
2ca02e9 to
0cd688b
Compare
Deydra71
force-pushed
the
appcred-support
branch
4 times, most recently
from
aafb90e to
e683b4d
Compare
auniyal61
left a comment
auniyal61
left a comment
There was a problem hiding this comment.
the kuttl test fail - GetACSecretName exist in keystone operator now
its because of dependency bump, can be in next PS
along with Kamil comment on test
Rest of the PR lgtm and works in my local deployment, thanks
| auth_type = v3applicationcredential | ||
| application_credential_id = {{ .ACID }} | ||
| application_credential_secret = {{ .ACSecret }} | ||
| {{ else -}} |
Deydra71
force-pushed
the
appcred-support
branch
from
e683b4d to
541dfe9
Compare
mrkisaolamb
force-pushed
the
appcred-support
branch
from
541dfe9 to
4ab2eaf
Compare
xek
force-pushed
the
appcred-support
branch
2 times, most recently
from
28880be to
3743f28
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
xek
force-pushed
the
appcred-support
branch
3 times, most recently
from
b539de5 to
51a8ffc
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
/retest-required |
|
/retest |
1 similar comment
|
/retest |
|
recheck |
|
/test placement-operator-build-deploy-kuttl |
xek
force-pushed
the
appcred-support
branch
3 times, most recently
from
b337941 to
036ffad
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Co-authored-by: Cursor <cursoragent@cursor.com>
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Deydra71, mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 7b903f2
into
openstack-k8s-operators:main
6 participants
Jira: OSPRH-16629
Adds the end-to-end support for consuming Keystone ApplicationCredentials (AC) in the Placement operator, enabling Placement pods to use AC-based authentication when available.
API changes:
Adds an optional authentication field to the Placement CR:
spec.auth.applicationCredentialSecret— name of the Secret that contains the Keystone Application Credential ID and Secret (AC_ID and AC_SECRET).Reconcile behavior:
Reads
spec.auth.applicationCredentialSecretAttempts to load AC_ID / AC_SECRET from the referenced Secret (via the Keystone helper).
If the secret is missing or incomplete, it falls back to password authentication (the AppCred auth is optional, not an error).
Depends-On: openstack-k8s-operators/keystone-operator#567