Skip to content

Ensure stable condition messages in ensureServiceExposed#406

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fmount:ecm
Apr 10, 2026
Merged

Ensure stable condition messages in ensureServiceExposed#406
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fmount:ecm

Conversation

@fmount
Copy link
Copy Markdown
Contributor

@fmount fmount commented Apr 3, 2026

Convert placementEndpoints map iteration to deterministic order using slices.Sorted(maps.Keys(...)) to prevent potential condition message instability across reconcile loops.

Related: OSPRH-28646

@fmount fmount requested a review from mrkisaolamb April 3, 2026 13:24
@openshift-ci openshift-ci Bot requested review from gibizer and stuggi April 3, 2026 13:24
Convert placementEndpoints map iteration to deterministic order
using slices.Sorted(maps.Keys(...)) to prevent potential condition
message instability across reconcile loops.

Related: OSPRH-28646

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Francesco Pantano <fpantano@redhat.com>
Copy link
Copy Markdown
Contributor

@mrkisaolamb mrkisaolamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, mrkisaolamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 2820640 into openstack-k8s-operators:main Apr 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants