Follow up on persistent storage changes (PR#107)#108
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test openstack-lightspeed-kuttl-4-18 Hmm wonder if my previous patch introduced a race condition when cleaning up the PVC for the test that does the custom size (not the default one) |
This patch addresses the latest review nits from PR#107. * Rename the database to "openstack-lightspeed-database" * Improve the info message when reusing an existing PVC with a matching size * Clean-up the PVC as part of the cleanup-openstack-lightspeed-instance.yaml kuttl test Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, lpiwowar, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
73411c1
into
openstack-lightspeed:lcore-migration
This patch addresses the latest review nits from PR#107.
size