[OSPRH-21185] Install OLS operator#27
Merged
openshift-merge-bot[bot] merged 10 commits intoNov 18, 2025
Merged
Conversation
lpiwowar
force-pushed
the
lpiwowar/OSPRH-21185
branch
from
86dc3ce to
ee1e2b8
Compare
umago
reviewed
Nov 6, 2025
lpiwowar
force-pushed
the
lpiwowar/OSPRH-21185
branch
2 times, most recently
from
f9dbd37 to
8b47be5
Compare
Implement automatic installation, version checking ,and lifecycle management of the OpenShift Lightspeed operator. Add support for both user-installed and instance-owned installation modes with proper ownership tracking. If the OLS operator has already been installed then the OpenStack Lightspeed operator checks it version. If the version is valied OpenStack Lightspeed utilizes the preinstalled OLS operator. If the OLS operator has not been already installed then the operator installs it. In this mode when the OpenStackLightspeed instance is created the OLS operator is automatically uninstalled as well. Whereas in the preinstalled OLS operator mode the OLS oeprator stays even after the removal of the OpenStackLightspeed instance.
Introduce a ping function that adds a random label to OLSConfig resources to trigger reconciliation by the OpenShift Lightspeed operator. This ensures the operator updates the Status field when the OLSConfig is not ready. This addresses a current limitation where the OLS operator does not automatically update the OLSConfig status when installed in the openstack-lightspeed namespace.
Because the OpenStack Lightspeed operator now depends on the OPENSHIFT_LIGTSPEED_OPERATOR_VERSION variable we have to ensure that it is set when we run the operator during development with make run.
lpiwowar
force-pushed
the
lpiwowar/OSPRH-21185
branch
from
8b47be5 to
4405e51
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update README to remove manual OLS operator deployment step since the operator now handles this automatically. This commit also renames the catalog-deploy to openstack-lightspeed-deploy to better reflect its behavior.
Update go.mod and go.sum with latest dependency versions.
Split RBAC permissions into cluster-scoped (read-only CSV list/watch) and namespace-scoped (CSV/subscription/installplan management) roles to support namespace-scoped operator deployment. Note that this commit adjusts the permissions that are related to the recent changes (OLS operator installation). In the follow up changes we have to modify the permissions for other resources as well.
Configure the operator to watch only the namespace specified in the WATCH_NAMESPACE environment variable instead of watching all namespaces cluster-wide. This enables namespace-scoped RBAC permissions for the operator. GetOLSOperatorCSV now uses a raw client to query CSVs cluster-wide, since the default controller client is scoped to WATCH_NAMESPACE.
lpiwowar
force-pushed
the
lpiwowar/OSPRH-21185
branch
from
4405e51 to
adba0a0
Compare
Contributor
Author
|
/hold We have to first figure out how we want to depend on the OLS Operator. If we decide that we still want to use the OLS operator to deploy OpenStack Lightspeed than we have to ensure that OLS team does not delete old versions of their operator from the OperatorHub. |
umago
reviewed
Nov 17, 2025
umago
left a comment
umago
left a comment
Contributor
There was a problem hiding this comment.
Code LGTM in general, left two ideas inline. Let me know what u think
Contributor
Author
|
@umago: I made the changes you wanted me to do. Let me know what you think:). For now, I kept the workaround in the PR [1]. The thing is that the [1] https://github.com/openstack-lightspeed/operator/pull/27/files |
Contributor
Author
|
/unhold I'm removing the hold label because we agreed that:
|
umago
reviewed
Nov 18, 2025
umago
left a comment
umago
left a comment
Contributor
There was a problem hiding this comment.
Few nits, other than that LGTM!
Default OPENSHIFT_LIGHTSPEED_OPERATOR_VERSION to "latest" to ensure compatibility with Operator Hub, which does not retain older versions indefinitely. Changes: - Set default version to "latest" in manager.yaml - Update GetRecommendedOLSVersion to handle "latest" value - Add SetStartingCSV helper to set version conditionally in Subscriptions - Return error when user-installed OLS operator is detected instead of attempting version compatibility check Future work should consider pinning to specific versions for production stability.
Install the OpenStack Lightspeed operator into the openshift-lightspeed namespace by default to align with ownership responsibilities and ensure compatibility, as the OLS operator is not guaranteed to function correctly in other namespaces.
lpiwowar
force-pushed
the
lpiwowar/OSPRH-21185
branch
from
b1bc750 to
1c63181
Compare
Contributor
|
/lgtm |
openshift-merge-bot
Bot
merged commit 0e1d583
into
openstack-lightspeed:main
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement automatic installation, version checking, and lifecycle management of the OpenShift Lightspeed operator. Add support for both user-installed and instance-owned installation modes, with proper ownership tracking.
If the OLS operator has already been installed, then the OpenStack lightspeed operator checks it version. If the version is valid OpenStack Lightspeed utilizes the preinstalled OLS operator.
If the OLS operator has not been already installed, then the operator installs it. In this mode, when the OpenStackLightspeed instance is created, the OLS operator is automatically uninstalled as well. Whereas in the preinstalled OLS operator mode, the OLS operator stays even after the removal of the OpenStackLightspeed instance.