Skip to content

Manually remove OLS installPlan on cleanup#41

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
lpiwowar:lpiwowar/delete-installplans
Nov 24, 2025
Merged

Manually remove OLS installPlan on cleanup#41
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
lpiwowar:lpiwowar/delete-installplans

Conversation

@lpiwowar

Copy link
Copy Markdown
Contributor

When the OpenStackLightspeed operator is installed via OLM, the OLM automatically adds ownership to the OLS installPlan created by our OLS Subcription, resultingin two owners:

  • The OLS Subscription (created by us)
  • The OpenStackLightspeed Subscription (created during the installation of the OpenStackLightspeed operator)

When uninstalling the OLS operator (because the user removed the OpenStackLightspeed instance) while OpenStackLightspeed continues running, the installPlan remains orphaned because the OpenStackLightspeed Subscription still exists. This change manually removes the installPlan during cleanup to prevent orphaned resources.

@openshift-ci

openshift-ci Bot commented Nov 21, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpiwowar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

When the OpenStackLightspeed operator is installed via OLM, the
OLM automatically adds ownership to the OLS installPlan created by
our OLS Subcription, resultingin two owners:

- The OLS Subscription (created by us)
- The OpenStackLightspeed Subscription (created during the installation
  of the OpenStackLightspeed operator)

When uninstalling the OLS operator (because the user removed the
OpenStackLightspeed instance) while OpenStackLightspeed continues
running, the installPlan remains orphaned because the OpenStackLightspeed
Subscription still exists. This change manually removes the installPlan
during cleanup to prevent orphaned resources.
@lpiwowar lpiwowar marked this pull request as ready for review November 21, 2025 14:16
@openshift-ci openshift-ci Bot requested review from Akrog and umago November 21, 2025 14:16
@lpiwowar lpiwowar force-pushed the lpiwowar/delete-installplans branch from 354ca13 to 8fb503f Compare November 21, 2025 14:17
@umago

umago commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Nov 24, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit b472db0 into openstack-lightspeed:main Nov 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants