Expose new config: LLMProjectID and LLMDeploymentName#64
Merged
openshift-merge-bot[bot] merged 1 commit intoJan 8, 2026
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
umago
force-pushed
the
llm-providers-config
branch
2 times, most recently
from
b9f5744 to
9a39693
Compare
Contributor
Author
|
/test openstack-lightspeed-kuttl-4-18 |
umago
force-pushed
the
llm-providers-config
branch
2 times, most recently
from
a81bc5c to
cd8a499
Compare
lpiwowar
reviewed
Jan 8, 2026
lpiwowar
left a comment
lpiwowar
left a comment
Contributor
There was a problem hiding this comment.
LGTM! 👍 Just one quick question.
In order to support Microsoft Azure OpenAI and WatsonX we need to expose these two new configurations in our operator. Microsoft Azure OpenAI requires the spec.llm.providers.deploymentName configuration to be set in OLSConfig [0]. Likewise, WatsonX requires the spec.llm.providers.projectID configuration to be set in OLSConfig [0]. The LLMDeploymentName and LLMProjectID exposed by us are optional configurations that can be set when configuring these LLM providers. Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
umago
force-pushed
the
llm-providers-config
branch
from
cd8a499 to
e393875
Compare
Contributor
|
/lgtm LGTM, thanks! 👍 |
openshift-merge-bot
Bot
merged commit fcb3884
into
openstack-lightspeed:main
7 checks passed
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support Microsoft Azure OpenAI and WatsonX we need to expose these two new configurations in our operator.
Microsoft Azure OpenAI requires the spec.llm.providers.deploymentName configuration to be set in OLSConfig [0].
Likewise, WatsonX requires the spec.llm.providers.projectID configuration to be set in OLSConfig [0].
The LLMDeploymentName and LLMProjectID exposed by us are optional configurations that can be set when configuring these LLM providers.