Skip to content

Allow feedback/transcripts to be disabled#69

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
umago:feedback-transcripts-config
Jan 20, 2026
Merged

Allow feedback/transcripts to be disabled#69
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
umago:feedback-transcripts-config

Conversation

@umago

@umago umago commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

This patch adds two new configuration options to OpenStack Lightspeed config:

  • FeedbackDisabled: If set to true, disable feedback collection
  • TranscriptsDisabled: If set to true, disable conversation transcripts collection

@openshift-ci openshift-ci Bot requested review from Akrog and lpiwowar January 16, 2026 16:40

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one blocking comment. Otherwise, looks good!

Comment thread internal/controller/funcs.go Outdated
This patch adds two new configuration options to OpenStack Lightspeed
config:

* FeedbackDisabled: If set to true, disable feedback collection
* TranscriptsDisabled: If set to true, disable conversation transcripts
collection

Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
@umago umago force-pushed the feedback-transcripts-config branch from 743bfaf to 9912eb3 Compare January 19, 2026 11:38

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 I'm leaving the final approval to @Akrog since he had some comments as well.

@Akrog Akrog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jan 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 10a6c55 into openstack-lightspeed:main Jan 20, 2026
7 checks passed
@umago umago deleted the feedback-transcripts-config branch March 10, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants