Skip to content

RELATED_IMAGE support and bundle warning fixes#76

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
dprince:relatedImages
Feb 5, 2026
Merged

RELATED_IMAGE support and bundle warning fixes#76
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
dprince:relatedImages

Conversation

@dprince

@dprince dprince commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

This PR adds support for RELATED_IMAGES to support offline airgapped images.

Additionally updates were made to bundle generation so that it runs cleanly without WARNINGS:

  • Update API domain from lightspeed.openstack.org to openstack.org and change group from api to lightspeed.
    -Remove generated bundle files from git and add them to .gitignore
    as these are generated files and do not need to be tracked.
    -set minimum Kubernetes version to 1.31.0 (corresponds to OCP 4.18)

Jira: OSPRH-25526

@openshift-ci openshift-ci Bot requested review from lpiwowar and umago January 31, 2026 12:40
@openshift-ci

openshift-ci Bot commented Jan 31, 2026

Copy link
Copy Markdown

Hi @dprince. Thanks for your PR.

I'm waiting for a openstack-lightspeed member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lpiwowar

lpiwowar commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@dprince

dprince commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

/test ci-index-openstack-lightspeed-bundle

@lpiwowar

lpiwowar commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

@dprince if you rebase on top of latest main the Kuttl tests should work now :) -> #76

This PR adds support for RELATED_IMAGES to support offline
airgapped images.

Additionally updates were made to bundle generation so
that it runs cleanly without WARNINGS:
 - Update API domain from lightspeed.openstack.org to openstack.org and                     change group from api to lightspeed.
 -set minimum Kubernetes version to 1.31.0 (corresponds to OCP 4.18)

Jira: OSPRH-25526

@lpiwowar lpiwowar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the help!

I think that as part of the ticket, we also have to deal with setting of the OPENSHIFT_LIGHTSPEED_OPERATOR_VERSION. But I assume we can do this similarly as the openstack-operator does for the OPENSTACK_RELEASE_VERSION in the bundle target in Makefile [1]. I can propose a separate PR.

[1] https://github.com/openstack-k8s-operators/openstack-operator/blob/a8f825c5a52c95a3e9a589164699e359065446f0/Makefile#L402

@umago

umago commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@umago

umago commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved label Feb 5, 2026
@openshift-ci

openshift-ci Bot commented Feb 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, lpiwowar, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 1d430c1 into openstack-lightspeed:main Feb 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants