RELATED_IMAGE support and bundle warning fixes#76
Conversation
|
Hi @dprince. Thanks for your PR. I'm waiting for a openstack-lightspeed member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/test ci-index-openstack-lightspeed-bundle |
9f698ab to
5e72109
Compare
This PR adds support for RELATED_IMAGES to support offline airgapped images. Additionally updates were made to bundle generation so that it runs cleanly without WARNINGS: - Update API domain from lightspeed.openstack.org to openstack.org and change group from api to lightspeed. -set minimum Kubernetes version to 1.31.0 (corresponds to OCP 4.18) Jira: OSPRH-25526
5e72109 to
0764340
Compare
lpiwowar
left a comment
There was a problem hiding this comment.
LGTM, thank you for the help!
I think that as part of the ticket, we also have to deal with setting of the OPENSHIFT_LIGHTSPEED_OPERATOR_VERSION. But I assume we can do this similarly as the openstack-operator does for the OPENSTACK_RELEASE_VERSION in the bundle target in Makefile [1]. I can propose a separate PR.
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, lpiwowar, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1d430c1
into
openstack-lightspeed:main
This PR adds support for RELATED_IMAGES to support offline airgapped images.
Additionally updates were made to bundle generation so that it runs cleanly without WARNINGS:
-Remove generated bundle files from git and add them to .gitignore
as these are generated files and do not need to be tracked.
-set minimum Kubernetes version to 1.31.0 (corresponds to OCP 4.18)
Jira: OSPRH-25526