Add valid-subscription annotation to CSV#96
Conversation
This annotation is optional in the operator spec [1] but actually required to release the operator downstream. It lists subscriptions required to use the operator. Let's use the same value as openstack-operator [2]. RELDEL-8649 [1] https://docs.okd.io/4.18/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-annotations-other_osdk-generating-csvs [2] https://github.com/openstack-k8s-operators/openstack-operator/blob/b950208d215e81f0cc2e0a9e6f6857a491d7f0c8/config/operator/manifests/bases/openstack-operator.clusterserviceversion.yaml#L14
|
Hi @compi-migui. Thanks for your PR. I'm waiting for a openstack-lightspeed member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo ClusterServiceVersion manifest files for OpenStack Lightspeed Operator were updated to add a subscription validation annotation listing valid OpenShift subscriptions. One file also received a timestamp update. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: compi-migui, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/lgtm |
f68c365
into
openstack-lightspeed:main
This annotation is optional in the operator spec [1] but actually required to release the operator downstream.
It lists subscriptions required to use the operator. Let's use the same value as openstack-operator [2].
RELDEL-8649
[1] https://docs.okd.io/4.18/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-annotations-other_osdk-generating-csvs
[2] https://github.com/openstack-k8s-operators/openstack-operator/blob/b950208d215e81f0cc2e0a9e6f6857a491d7f0c8/config/operator/manifests/bases/openstack-operator.clusterserviceversion.yaml#L14
Summary by CodeRabbit