Skip to content

Add valid-subscription annotation to CSV#96

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
compi-migui:migarcia-add-valid-subscription-annotation
Apr 15, 2026
Merged

Add valid-subscription annotation to CSV#96
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
compi-migui:migarcia-add-valid-subscription-annotation

Conversation

@compi-migui

@compi-migui compi-migui commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

This annotation is optional in the operator spec [1] but actually required to release the operator downstream.

It lists subscriptions required to use the operator. Let's use the same value as openstack-operator [2].

RELDEL-8649

[1] https://docs.okd.io/4.18/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-annotations-other_osdk-generating-csvs
[2] https://github.com/openstack-k8s-operators/openstack-operator/blob/b950208d215e81f0cc2e0a9e6f6857a491d7f0c8/config/operator/manifests/bases/openstack-operator.clusterserviceversion.yaml#L14

Summary by CodeRabbit

  • Chores
    • Updated operator metadata annotations to specify valid OpenShift subscriptions: OpenShift Container Platform and OpenShift Platform Plus.
    • Updated operator metadata timestamp.

This annotation is optional in the operator spec [1] but actually
required to release the operator downstream.

It lists subscriptions required to use the operator. Let's use the same
value as openstack-operator [2].

RELDEL-8649

[1] https://docs.okd.io/4.18/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-annotations-other_osdk-generating-csvs
[2] https://github.com/openstack-k8s-operators/openstack-operator/blob/b950208d215e81f0cc2e0a9e6f6857a491d7f0c8/config/operator/manifests/bases/openstack-operator.clusterserviceversion.yaml#L14
@openshift-ci openshift-ci Bot requested review from Akrog and umago April 15, 2026 08:08
@openshift-ci

openshift-ci Bot commented Apr 15, 2026

Copy link
Copy Markdown

Hi @compi-migui. Thanks for your PR.

I'm waiting for a openstack-lightspeed member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Apr 15, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e51cf810-779a-4ef3-b77c-5c5d8e25c75e

📥 Commits

Reviewing files that changed from the base of the PR and between 55ffb15 and bc8580e.

📒 Files selected for processing (2)
  • bundle/manifests/openstack-lightspeed-operator.clusterserviceversion.yaml
  • config/manifests/bases/openstack-lightspeed-operator.clusterserviceversion.yaml

📝 Walkthrough

Walkthrough

Two ClusterServiceVersion manifest files for OpenStack Lightspeed Operator were updated to add a subscription validation annotation listing valid OpenShift subscriptions. One file also received a timestamp update.

Changes

Cohort / File(s) Summary
ClusterServiceVersion Subscription Metadata
bundle/manifests/openstack-lightspeed-operator.clusterserviceversion.yaml, config/manifests/bases/openstack-lightspeed-operator.clusterserviceversion.yaml
Added operators.openshift.io/valid-subscription annotation specifying valid OpenShift subscriptions as ["OpenShift Container Platform", "OpenShift Platform Plus"]. Bundle manifest also updated createdAt timestamp from 2026-02-19T13:45:56Z to 2026-04-15T07:57:01Z.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop, hop, our metadata springs to life,
New subscriptions validated, free from strife,
Timestamps tick forward, annotations shine,
OpenShift paths now perfectly align! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the valid-subscription annotation to the ClusterServiceVersion (CSV) manifest files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lpiwowar

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci

openshift-ci Bot commented Apr 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: compi-migui, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lpiwowar

Copy link
Copy Markdown
Contributor

/lgtm

@umago

umago commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-merge-bot openshift-merge-bot Bot merged commit f68c365 into openstack-lightspeed:main Apr 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants